Opened 12 years ago
Closed 12 years ago
#23752 closed enhancement (fixed)
Update hoverIntent to r7
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | External Libraries | Keywords: | has-patch |
Focuses: | Cc: |
Description
I'd like to request that hoverIntent be updated to hoverIntent r7.
hoverIntent.js has just been updated to support event delegation whilst still being backward-compatible. My Superfish menu plugin requires this, meaning that when users set hoverIntent as a dependency they have to dequeue WordPress's version of hoverIntent and requeue the updated version, which is awkward, and their dropdown menus will not work at all without it.
Also, whatever WordPress uses hoverIntent for should benefit from using event delegation in future.
External library: https://github.com/briancherne/jquery-hoverIntent
Attachments (3)
Change History (12)
#2
@
12 years ago
Added patch to update hoverintent to r7. This new version required jQuery 1.9.1+, which is what's being bundled with 3.6, so it runs with no problem (as long as people aren't using their own version of jQuery, which they shouldn't be anyway).
#3
follow-up:
↓ 6
@
12 years ago
- Keywords has-patch added
Wasn't sure if I should add has-patch here or a Core maintainer does that (my first Core patch, be gentle).
#6
in reply to:
↑ 3
@
12 years ago
Replying to mjbanks:
Wasn't sure if I should add has-patch here or a Core maintainer does that (my first Core patch, be gentle).
If you add a patch, you should add the has-patch keyword yourself. Most committers look at tickets with has-patch first so they can commit those. If it needs extra testing, add needs-testing, and if it needs someone else to look over it, add dev-feedback. Simple! :)
#7
follow-up:
↓ 8
@
12 years ago
We should remove the minfied version at some time, see #21769.
@mjbanks:
Can you please update wp-includes/admin-bar,js
too? It includes the minified version.
upgrade hoverintent to r7, both full and minified version (via uglify)