remove_menu_page: Check for existing menu items

[sergej.mueller]

This error appears in my error log:

PHP Warning: Invalid argument supplied for foreach() in /www/htdocs/wp-admin/includes/plugin.php on line 1290

The if-empty patch is attached.

[SergeyBiryukov]

Looks like there are only three ways to get this warning:

1. Call remove_menu_page() after the admin is fully loaded, but before $menu global is set up, e.g. by hooking into auth_redirect action instead of admin_menu, which goes against the Codex example: ​http://codex.wordpress.org/Function_Reference/remove_menu_page.
2. Call remove_menu_page() on the admin_init hook instead of admin_menu. As noted in #19937, admin_init fires in some situations where there is no UI for which a menu will be built.
3. Manually unset the $menu global at some point.

These are all developer errors, so the developer should see the warning.

[sergej.mueller]

Any foreach command should be checked "if empty".

[SergeyBiryukov]

Similar enhancements were suggested in #17299 and #18927.

The consensus was that we shouldn't hide warnings generated by plugin or theme bugs. That would only make debugging harder.

[c3mdigital]

We shouldn't accommodate for developer errors.

[SergeyBiryukov]

#43714 was marked as a duplicate.

[SergeyBiryukov]

#42538 was marked as a duplicate.

[SergeyBiryukov]

#51254 was marked as a duplicate.