Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#23769 closed defect (bug) (fixed)

Twenty Thirteen: Captions cover image links in galleries with many columns

Reported by: kwight's profile kwight Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch needs-refresh
Focuses: Cc:

Description

In single views, the fixed height of gallery captions makes image links inaccessible in galleries with seven columns or more. The problem also happens with lower numbers of columns as screen width narrows.

Attachments (3)

caption-hiding-image-link.png (151.4 KB) - added by kwight 10 years ago.
23769.diff (1.1 KB) - added by kwight 10 years ago.
23769.2.diff (667 bytes) - added by kwight 10 years ago.

Download all attachments as: .zip

Change History (8)

@kwight
10 years ago

#1 @kwight
10 years ago

Patch 23769:

  • hides captions for galleries with 7 columns or more
  • hides captions for galleries with 4, 5, or 6 columns at the 643px breakpoint
  • ensures captions are never more than 50% of their image

The 50% max-height makes sure that there is always clickable space for the image link, which becomes more important on touch devices with smaller physical screens.

#2 @lancewillett
10 years ago

  • Milestone changed from Awaiting Review to 3.6

#3 @lancewillett
10 years ago

  • Keywords needs-refresh added

Discussed in office hours:

  • Yes, hide for 7 columns or more
  • Hide for all columns in smaller screens (any touch device, basically, phone or table won't be able to see the captions anyway)
  • Try to style the captions so that one-word, one-sentence captions don't need to take up as much height

@kwight
10 years ago

#4 @kwight
10 years ago

23769.2.diff:

  • remove captions on all 7, 8, and 9-column galleries
  • remove captions for all galleries at 767px and below

#5 @lancewillett
10 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23700:

Twenty Thirteen: hide gallery captions from small screens and when a gallery has 7 columns or more. Props kwight, fixes #23769.

Note: See TracTickets for help on using tickets.