WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#23773 closed defect (bug) (fixed)

Twenty Thirteen: short captions still cover at least 50% of their gallery image

Reported by: kwight Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Even if a caption is only a word or two, its fixed height will force it to always cover at least 50% of its image in a single view gallery.

Attachments (5)

single-word-caption.png (268.1 KB) - added by kwight 8 years ago.
23773.diff (704 bytes) - added by kwight 8 years ago.
23773diff.png (384.2 KB) - added by kwight 8 years ago.
23773.2.diff (704 bytes) - added by kwight 8 years ago.
23773.3.diff (704 bytes) - added by kwight 8 years ago.

Download all attachments as: .zip

Change History (10)

@kwight
8 years ago

#1 @kwight
8 years ago

23773.diff:

  • no fixed height for captions, only as high as they need to be
  • caption has a maximum height of 75%, ensuring there is always clickable space for the image link
  • minimum height for the box-shadow, keeping it out of frame for all captions but those at or exceeding the maximum size

@kwight
8 years ago

#2 @lancewillett
8 years ago

  • Milestone changed from Awaiting Review to 3.6

#3 @obenland
8 years ago

I'd vote to leave it at 50% height though, as this is how Joen intended it to be.
Nice patch Kirk!

@kwight
8 years ago

@kwight
8 years ago

#4 @kwight
8 years ago

23773.3.diff: same as 23773.diff, but with a max-height of 50%, and proper ordering (I think?) of declarations.

My pleasure, such a fun design to work on :)

#5 @lancewillett
8 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23701:

Twenty Thirteen: better caption styles for short words and sentences. Props kwight, fixes #23773.

Note: See TracTickets for help on using tickets.