WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #23776, comment 12


Ignore:
Timestamp:
06/13/2014 02:19:05 PM (7 years ago)
Author:
UmeshSingla
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23776, comment 12

    initial v1  
    22> I think `$this->linkifunknown` should be left as is, it's used in [source:tags/3.9.1/src/wp-includes/class-wp-embed.php#L314 WP_Embed::maybe_make_link()] (as noted in comment:1:ticket:20315).
    33
    4 For `autoembed_callback` it is dead code, $this->linkifunknown is set to false before calling shortocode function. As a result if there is a link in content it is never being converted to a link, it is left as it is, which is wrong, as per **Once found, it tries to embed it and if it is unable to, then it hyperlinks the URL**
     4For `autoembed_callback` it is dead code, $this->linkifunknown is set to false before calling shortocode function. As a result if there is a link in content it is never being converted to a link unless it is a youtube, vimeo or other known service link, it is left as it is, which is wrong, as per **Once found, it tries to embed it and if it is unable to, then it hyperlinks the URL**