WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#23784 closed enhancement (fixed)

Twenty Thirteen: Post format and link color tweaks for consistency

Reported by: Joen Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

I discovered that a couple of the post format background colors (video, audio, gallery, quote) were slightly off compared to mockups: http://cl.ly/image/3b0O21090o2E — it's a small change, probably due to a color profile mismatch on my part. The new colors are a *teensy* bit more muted.

Additionally, link colors should be consistent. For example, standard, link and aside post formats should have same link color for meta and entry-content, for the sake of simplicity and consistency.

The updated colors in this patch pass WebAIM color contrast checker (http://webaim.org/resources/contrastchecker/) to ensure proper readability.

Attachments (1)

colortweaks.diff (3.1 KB) - added by Joen 4 years ago.
Patch to tweak off post format colors, and make link colors consistent.

Download all attachments as: .zip

Change History (9)

@Joen
4 years ago

Patch to tweak off post format colors, and make link colors consistent.

#1 @obenland
4 years ago

  • Milestone changed from Awaiting Review to 3.6

#2 follow-up: @lancewillett
4 years ago

Joen: changes look good, thank you.

I assumed this selector change was not intentional, though:

.format-quote .entry-content .page-links a, 

so I left it out.

#3 @lancewillett
4 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23756:

Twenty Thirteen: post format and link color tweaks for consistency, props joen. Fixes #23784.

#4 @lancewillett
4 years ago

Two small notes for making patches for core Trac:

  1. Make the patch from WordPress root (not inside the theme directory)
  2. Name it [the ticket number].diff

Both those help patches like me a ton applying and testing out lots of patches. :)

#5 in reply to: ↑ 2 @Joen
4 years ago

Replying to lancewillett:

Joen: changes look good, thank you.

I assumed this selector change was not intentional, though:

.format-quote .entry-content .page-links a, 

so I left it out.

I think it was actually intentional — otherwise I get this on my test setup:
http://cl.ly/image/3u261v3N3I2I

Thanks for the info on the patches, this is actually my first actual core contribution. I'm making a mental note, because I hope to make many more contributions.

#6 @SergeyBiryukov
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @lancewillett
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 23771:

Twenty Thirteen: quote post format color fix for paging links, props Joen. Closes #23784.

#8 @lancewillett
4 years ago

In 23962:

Twenty Thirteen: minor design tweaks and fixes:

  • Link color should be the same on all links that are on white or tan backgrounds, see #23784
  • Better color value for active menu item (red instead of tan)
  • Improved styles for quote citations that are wrapped in links
  • Better layout for single post navigation links when post titles are really long
  • Fix navbar border style for viewports at 1600 pixels wide and above

Props Joen and obenland.

Note: See TracTickets for help on using tickets.