#23784 closed enhancement (fixed)
Twenty Thirteen: Post format and link color tweaks for consistency
Reported by: | Joen | Owned by: | lancewillett |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
I discovered that a couple of the post format background colors (video, audio, gallery, quote) were slightly off compared to mockups: http://cl.ly/image/3b0O21090o2E — it's a small change, probably due to a color profile mismatch on my part. The new colors are a *teensy* bit more muted.
Additionally, link colors should be consistent. For example, standard, link and aside post formats should have same link color for meta and entry-content, for the sake of simplicity and consistency.
The updated colors in this patch pass WebAIM color contrast checker (http://webaim.org/resources/contrastchecker/) to ensure proper readability.
Attachments (1)
Change History (9)
#2
follow-up:
↓ 5
@
11 years ago
Joen: changes look good, thank you.
I assumed this selector change was not intentional, though:
.format-quote .entry-content .page-links a,
so I left it out.
#3
@
11 years ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In 23756:
#4
@
11 years ago
Two small notes for making patches for core Trac:
- Make the patch from WordPress root (not inside the theme directory)
- Name it [the ticket number].diff
Both those help patches like me a ton applying and testing out lots of patches. :)
#5
in reply to:
↑ 2
@
11 years ago
Replying to lancewillett:
Joen: changes look good, thank you.
I assumed this selector change was not intentional, though:
.format-quote .entry-content .page-links a,so I left it out.
I think it was actually intentional — otherwise I get this on my test setup:
http://cl.ly/image/3u261v3N3I2I
Thanks for the info on the patches, this is actually my first actual core contribution. I'm making a mental note, because I hope to make many more contributions.
Patch to tweak off post format colors, and make link colors consistent.