WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 3 months ago

#23785 closed enhancement (wontfix)

highlight rows on hover for tables with widefat class

Reported by: cfoellmann Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.5
Component: Administration Keywords:
Focuses: ui Cc:

Description

If .widefat tables had this css code system-wide (wp-admin.css)

.widefat tr:hover td {
      background-color: #DDD;
}

handling these tables on (extreme) widescreens would be improved.

http://picload.org/image/aocipap/widefat.jpg

Attachments (1)

23785.diff (398 bytes) - added by MikeHansenMe 11 months ago.
Adds transparent color on hover to match Blue and Gray color schemes

Download all attachments as: .zip

Change History (7)

comment:1 helen13 months ago

  • Component changed from Accessibility to Administration
  • Keywords ui-focus added; ui-feedback removed

Not sure - would want to know if this is something generally desirable or considered distracting. It's a pretty common pattern but that doesn't make it not distracting, especially when hover already brings up other things like row action links.

If this were to happen, patches would need to consider the blue color scheme and perhaps the zebra striping. Also contrast, especially between background and foreground.

comment:2 SergeyBiryukov13 months ago

  • Version changed from trunk to 3.5

comment:3 nacin13 months ago

As a common pattern, it really only makes sense if you're dealing with an absolute ton of data or if the hover then signifies that the row can be clicked. Differentiating rows is very much mitigated by the zebra-striping. This is a wontfix in my book.

comment:4 MikeHansenMe13 months ago

  • Cc mdhansen@… added

I like this addition. I do think it is most useful when there is a ton of data but do not think it is distracting with little amounts. It also helps the eye follow which row you are looking at(beyond the existing zebra stripe). Perhaps we should leave this open to get a few more opinions.

To see this in action, just look at trac on a wide screen.

Last edited 13 months ago by MikeHansenMe (previous) (diff)

MikeHansenMe11 months ago

Adds transparent color on hover to match Blue and Gray color schemes

comment:5 sillybean9 months ago

I like the idea, but I agree with Helen that it could easily become a distraction on tables that already change things on hover, like the quick edit links.

What if, instead of adding this to all widefat tables, we add a new class, highlight? It would be available to core/plugin devs but not applied by default.

comment:6 helen3 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

There are some helper classes in core now for highlight colors and such, which can be further refined generically in another ticket or elsewhere if so desired. Closing this as wontfix, per nacin's comment and my own concerns.

Note: See TracTickets for help on using tickets.