WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#2379 closed defect (bug) (fixed)

RSS feeds broken in 2.01

Reported by: incursio Owned by:
Milestone: Priority: highest omg bbq
Severity: critical Version: 2.0
Component: General Keywords: rss xml
Focuses: Cc:

Description

As reported in several forum threads.

Sometimes, we get just comments, and no posts in the RSS thread. I vaguely remember seeing an option in the admin panel to choose posts vs comments but with 2.01 it seems to have disappeared.

Plus, RSS feeds do not package into XML properly when encountering an ampersand. They are breaking - also reported in forums.

Attachments (1)

comments-fix.txt (617 bytes) - added by joshkidd 8 years ago.
fix for comments bug

Download all attachments as: .zip

Change History (16)

comment:1 incursio8 years ago

  • Version changed from 1.2 to 2.0

comment:2 incursio8 years ago

Followup/summary:

This works fine:
http://www.scottburkett.com/?feed=rss2

These show only comments, no posts:
http://www.scottburkett.com/index.php/feed
http://www.scottburkett.com/index.php/feed/rss
http://www.scottburkett.com/index.php/feed/atom

Unfortunately, Technorati automatically tries to pull the last 3 examples, not the first, so new posts are not getting indexed there (which sucks).

Cheers.

comment:3 jdybka8 years ago

Hello

Same problem here.

Shows only comments (no posts):
http://www.poetryhut.com/wordpress/index.php/feed/

Shows only comments (no posts):
http://www.poetryhut.com/wordpress/index.php/feed/rss

Shows only comments (no posts):
http://www.poetryhut.com/wordpress/index.php/feed/atom

Shows only comments (works correctly):
http://www.poetryhut.com/wordpress/index.php/comments/feed/

This feed also works correctly:
http://www.poetryhut.com/wordpress/index.php?feed=rss2

My permalinks structure is set to "Date and name based."

Thanks
Jilly

joshkidd8 years ago

fix for comments bug

comment:4 joshkidd8 years ago

I had the same problem reported in the comments on this bug. The attached file is a change that I made to the code. After making the change, I had to create a new static page to flush the rewrite rules. Now, I get the behavior I expect:

Shows posts: http://larameekidd.com/index.php/feed
Shows comments: http://larameekidd.com/index.php/comments/feed

comment:5 jdybka8 years ago

Thank you. That fixed my problem. To flush the rewrite rules I changed my permalinks structure from "Date and name based" to another structure and then back again.

comment:6 jbwhong8 years ago

Joshkidd, to which file do I apply your modification?

comment:7 joshkidd8 years ago

As it says in the file, the change is to be applied to wp-includes/classes.php

comment:8 ryan8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3527]) Don't walk rewrite structure when generating comment feed rewrite rules. This fixes a bug uncovered when we switched from unions to merges. Props joshkidd. fixes #2379

comment:9 ryan8 years ago

  • Milestone set to 2.1

comment:10 jbwhong8 years ago

It's not my software project, but here are my two cents:

A bug this big (that breaks people's subscriptions) shouldn't wait for a distant 2.1 release.

Now that this ticket is closed you are getting others submitting duplicate tickets.

Perhaps a 2.0.2 release is in order.

comment:11 jbwhong8 years ago

Joshkidd, sorry I couldn't figure out what file to patch based on reading the file.

How can I use your patch?

comment:12 davidhouse8 years ago

jbwhong:

The file you need to patch is wp-includes/classes.php, as it says at the top of the patch. Simply search that file for the line with the '-' in front of it in the patch (it won't actually have a - in the actual classes.php file), then replace it with the line with the '+' in front of it in the patch (again, don't actually put the + in the file, but the rest of the line).

comment:13 ryan8 years ago

  • Resolution set to fixed

(In [3551]) Don't walk rewrite structure when generating comment feed rewrite rules. This fixes a bug uncovered when we switched from unions to merges. Props joshkidd. fixes #2379

comment:14 ryan8 years ago

  • Milestone changed from 2.1 to 2.0.2

comment:15 anonymous7 years ago

  • Milestone 2.0.2 deleted

Milestone 2.0.2 deleted

Note: See TracTickets for help on using tickets.