#23790 closed defect (bug) (fixed)
Twenty Twelve: Add Google font support to custom header admin
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
Related: #22499
We should also add Open Sans to the custom header admin, to correctly display the site title and description.
Attachments (4)
Change History (14)
#3
@
12 years ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In 23717:
#4
follow-up:
↓ 5
@
12 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
In [23717], there are 3 instances of zero width space before the font names.
23790.2.diff fixes that.
#5
in reply to:
↑ 4
;
follow-up:
↓ 8
@
12 years ago
Replying to SergeyBiryukov:
In [23717], there are 3 instances of zero width space before the font names.
Good catch! How did you find that?
#8
in reply to:
↑ 5
;
follow-up:
↓ 9
@
12 years ago
Replying to lancewillett:
Good catch! How did you find that?
Noticed in the editors I use (Far Manager and Notepad++) while preparing a patch for #24033.
#9
in reply to:
↑ 8
;
follow-up:
↓ 10
@
12 years ago
Replying to SergeyBiryukov:
Replying to lancewillett:
Good catch! How did you find that?
Noticed in the editors I use (Far Manager and Notepad++) while preparing a patch for #24033.
Do you have a setting turned on for "show invisible characters" or something like that?
#10
in reply to:
↑ 9
@
12 years ago
Replying to lancewillett:
Do you have a setting turned on for "show invisible characters" or something like that?
Just for whitespace and tabs. Zero-width spaces showed up as empty squares: 23790.zero-width-space.png.
Quick notes, also '444' mention in a PHP comment (near line 66) -- and probably should use
font_url
singular as the variable name (to match the functions.php change, and since it's only one font).