WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#23790 closed defect (bug) (fixed)

Twenty Twelve: Add Google font support to custom header admin

Reported by: obenland Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Related: #22499

We should also add Open Sans to the custom header admin, to correctly display the site title and description.

Attachments (4)

23790.diff (1.9 KB) - added by obenland 6 years ago.
23790.1.diff (2.1 KB) - added by obenland 6 years ago.
23790.2.diff (577 bytes) - added by SergeyBiryukov 6 years ago.
23790.zero-width-space.png (90.4 KB) - added by SergeyBiryukov 6 years ago.

Download all attachments as: .zip

Change History (14)

@obenland
6 years ago

#1 @obenland
6 years ago

  • Keywords has-patch added

#2 @lancewillett
6 years ago

Quick notes, also '444' mention in a PHP comment (near line 66) -- and probably should use font_url singular as the variable name (to match the functions.php change, and since it's only one font).

@obenland
6 years ago

#3 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23717:

Twenty Twelve: improve Appearance > Header styles to match front end view better -- including loading special Google Font there. Props obenland, fixes #23790.

#4 follow-up: @SergeyBiryukov
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

In [23717], there are 3 instances of zero width space before the font names.

23790.2.diff fixes that.

#5 in reply to: ↑ 4 ; follow-up: @lancewillett
6 years ago

Replying to SergeyBiryukov:

In [23717], there are 3 instances of zero width space before the font names.

Good catch! How did you find that?

#6 @lancewillett
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 24013:

Twenty Twelve: remove zero-width spaces in CSS value, props SergeyBiryukov. Closes #23790.

#7 @lancewillett
6 years ago

In 24014:

Twenty Twelve: add back missing space in CSS value, removed in r24013. See #23790.

#8 in reply to: ↑ 5 ; follow-up: @SergeyBiryukov
6 years ago

Replying to lancewillett:

Good catch! How did you find that?

Noticed in the editors I use (Far Manager and Notepad++) while preparing a patch for #24033.

#9 in reply to: ↑ 8 ; follow-up: @lancewillett
6 years ago

Replying to SergeyBiryukov:

Replying to lancewillett:

Good catch! How did you find that?

Noticed in the editors I use (Far Manager and Notepad++) while preparing a patch for #24033.

Do you have a setting turned on for "show invisible characters" or something like that?

#10 in reply to: ↑ 9 @SergeyBiryukov
6 years ago

Replying to lancewillett:

Do you have a setting turned on for "show invisible characters" or something like that?

Just for whitespace and tabs. Zero-width spaces showed up as empty squares: 23790.zero-width-space.png.

Note: See TracTickets for help on using tickets.