Opened 12 years ago
Closed 12 years ago
#23798 closed defect (bug) (fixed)
Audio: Fallback link gets cropped by fixed-height container.
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Media | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
The "Download File" fallback for the audio shortcode is hard to read in all of my tests. Here are some screenshots:
I tested with a WMA file. It appears that the .me-cannotplay
element is given a height greater than .wp-audio-shortcode
. I've observed this in Both Chrome and Firefox.
A possible solution is to display a simple text link in a paragraph that would inherit style already provided by the theme. This would also ensure that the text is always readable in cases where the user's fontsize is bumped to a large value which would be cut-off by the hardcoded 30px height of .wp-audio-shortcode
.
Attachments (5)
Change History (16)
#2
@
12 years ago
I have attached what we in the business call a "HACK" that makes the error state contort into a plain old link. MediaElement allows you to hook into the error, but the custom code runs after that player is rendered in its own error state. If anyone else wants to take a look at this, have at it!
#3
@
12 years ago
- Keywords has-patch added
I think MediaElement should not be trying to handle files it does not support. 23798.2.diff falls back to a regular link for unsupported audio. Also related: #24076
#4
@
12 years ago
- Component changed from Shortcodes to Media
- Keywords commit added
- Summary changed from Audio Shortcode: Fallback link gets cropped by fixed-height container. to Audio: Fallback link gets cropped by fixed-height container.
#6
@
12 years ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In 24519:
#7
@
12 years ago
Testing today at WCSF dev day, noticed that on iOS mobile browsers, fallback me-cannotplay div breaks site layout because it has hardcoded height and width values. See attached screenshots for iOS Chrome and Safari. Any default theme has this issue.
#8
@
12 years ago
If we change the hardcoded height and width of the me-cannotplay element to auto, issue is resolved.
#9
@
12 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Re-opening for review.
Related: #23282