WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#23799 closed defect (bug) (fixed)

Twenty Thirteen: Untranslatable string in image.php

Reported by: Jayjdk Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The "View full X × Y resolution" string in image.php in Twenty Thirteen is untranslatable.

The attached patch fixes it.

Attachments (6)

23799.patch (779 bytes) - added by Jayjdk 2 years ago.
23799.2.patch (1.1 KB) - added by DrewAPicture 2 years ago.
23799.3.patch (1.0 KB) - added by DrewAPicture 2 years ago.
23799.4.patch (966 bytes) - added by Jayjdk 2 years ago.
Removes the dimensions from the string
23799.5.patch (857 bytes) - added by lancewillett 2 years ago.
23799.6.patch (852 bytes) - added by lancewillett 2 years ago.

Download all attachments as: .zip

Change History (13)

@Jayjdk2 years ago

comment:1 @DrewAPicture2 years ago

  • Milestone changed from Awaiting Review to 3.6

23799.2.patch takes a more structured approach, so we can avoid having all that extra markup in the string. Also converts the height and width specifiers to decimal.

@DrewAPicture2 years ago

comment:2 @DrewAPicture2 years ago

Looks like I accidentally flipped the order in the printf in 23799.2.patch. The URL should be first, title second, anchor third. I'll fix it in a little while.

@DrewAPicture2 years ago

comment:3 @lancewillett2 years ago

I think the "view full resolution" should leave out the dimensions entirely, just simplify the text a bit.

@Jayjdk2 years ago

Removes the dimensions from the string

@lancewillett2 years ago

comment:4 @lancewillett2 years ago

Was thinking more like .5 patch -- the width and height can be output but don't need to be translated.

@lancewillett2 years ago

comment:5 @lancewillett2 years ago

.6 is even simpler.

comment:6 @Jayjdk2 years ago

What if the order is changed in some languages? What about a combination of .3 and .6? So .3 is changed to have the wording of .6

Last edited 2 years ago by Jayjdk (previous) (diff)

comment:7 @lancewillett2 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23758:

Twenty Thirteen: fix translation string in image template, fixes #23799.

Note: See TracTickets for help on using tickets.