WordPress.org

Make WordPress Core

#23802 closed defect (bug) (fixed)

Twenty Thirteen: Closing container comments

Reported by: DrewAPicture Owned by: lancewillett
Milestone: 3.6 Priority: low
Severity: trivial Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Definitely kind of a nit, but I feel like we should be consistent with using closing comments on containers spanning multiple lines.

Patch attached.

Attachments (2)

23802.diff (8.7 KB) - added by DrewAPicture 13 months ago.
23802.2.diff (3.3 KB) - added by lancewillett 13 months ago.

Download all attachments as: .zip

Change History (7)

DrewAPicture13 months ago

comment:1 DrewAPicture13 months ago

  • Severity changed from normal to trivial

comment:2 follow-up: alexvorn213 months ago

why headings too?

comment:3 in reply to: ↑ 2 DrewAPicture13 months ago

Replying to alexvorn2:

why headings too?

Consistency. Either label all the multi-line <header>/<h#> tags or don't label any of them.

lancewillett13 months ago

comment:4 lancewillett13 months ago

  • Milestone changed from Awaiting Review to 3.6

Patch starts from Drew's, but removes end comments for titles and removes from custom-header.php (not needed).

comment:5 lancewillett13 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23755:

Twenty Thirteen: fix a few closing container comments. Props to DrewAPicture for the initial patch. Fixes #23802.

Note: See TracTickets for help on using tickets.