WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#23802 closed defect (bug) (fixed)

Twenty Thirteen: Closing container comments

Reported by: drewapicture's profile DrewAPicture Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: low
Severity: trivial Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Definitely kind of a nit, but I feel like we should be consistent with using closing comments on containers spanning multiple lines.

Patch attached.

Attachments (2)

23802.diff​ (8.7 KB) - added by DrewAPicture 12 years ago.
23802.2.diff​ (3.3 KB) - added by lancewillett 12 years ago.

Download all attachments as: .zip

Change History (7)

@DrewAPicture
12 years ago

#1 @DrewAPicture
12 years ago

  • Severity changed from normal to trivial

#2 follow-up: @alexvorn2
12 years ago

why headings too?

#3 in reply to: ↑ 2 @DrewAPicture
12 years ago

Replying to alexvorn2:

why headings too?

Consistency. Either label all the multi-line <header>/<h#> tags or don't label any of them.

@lancewillett
12 years ago

#4 @lancewillett
12 years ago

  • Milestone changed from Awaiting Review to 3.6

Patch starts from Drew's, but removes end comments for titles and removes from custom-header.php (not needed).

#5 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23755:

Twenty Thirteen: fix a few closing container comments. Props to DrewAPicture for the initial patch. Fixes #23802.

Note: See TracTickets for help on using tickets.