PHP Strict Mode : Bulk_Plugin_Upgrader_Skin::before() warning

[charlestonsw]

This is from core WP 3.5.1 on my dev box while installing the Debug Bar plugin. This is not the first plugin to trigger this message while testing. I do have strict mode and full warnings/debug messages enabled throughout WordPress and PHP.

Strict Standards: Declaration of Bulk_Plugin_Upgrader_Skin::before() should be compatible with that of Bulk_Upgrader_Skin::before() in /var/www/html/wp-admin/includes/class-wp-upgrader.php on line 1359
Strict Standards: Declaration of Bulk_Plugin_Upgrader_Skin::after() should be compatible with that of Bulk_Upgrader_Skin::after() in /var/www/html/wp-admin/includes/class-wp-upgrader.php on line 1359 
Strict Standards: Declaration of Bulk_Theme_Upgrader_Skin::before() should be compatible with that of Bulk_Upgrader_Skin::before() in /var/www/html/wp-admin/includes/class-wp-upgrader.php on line 1394 
Strict Standards: Declaration of Bulk_Theme_Upgrader_Skin::after() should be compatible with that of Bulk_Upgrader_Skin::after() in /var/www/html/wp-admin/includes/class-wp-upgrader.php on line 1394 

[charlestonsw]

I believe this patch addresses the problem.

[ryan]

In 23749:

Make the before() and after() methods in Bulk_Plugin_Upgrader_Skin and Bulk_Theme_Upgrader_Skin declarations match Bulk_Upgrader_Skin. Eliminates strict standards warning.

Props charlestonsw
fixes #23807

[soulseekah]

Does Bulk_Upgrader_Skin also have to match the declarations of the above methods in WP_Upgrader_Skin?

[SergeyBiryukov]

Replying to soulseekah:

Does Bulk_Upgrader_Skin also have to match the declarations of the above methods in WP_Upgrader_Skin?

Well, it doesn't produce the strict standards warning, so I guess we're good. As far as I can see, adding new optional arguments in overridden methods is fine, removing or changing existing arguments is not.

[charlestonsw]

I believe this patch was already added in a prior release. Not sure why the ticket was not closed but the warning went away in a post 3.5.1 release.

[SergeyBiryukov]

The ticket is closed as fixed in 3.6 ([23749]).