![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#23807 closed defect (bug) (fixed)
PHP Strict Mode : Bulk_Plugin_Upgrader_Skin::before() warning
| Reported by: | charlestonsw | Owned by: | ryan |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Warnings/Notices | Version: | 3.5.1 |
| Severity: | minor | Keywords: | |
| Cc: | Focuses: |
Description (last modified by )
This is from core WP 3.5.1 on my dev box while installing the Debug Bar plugin. This is not the first plugin to trigger this message while testing. I do have strict mode and full warnings/debug messages enabled throughout WordPress and PHP.
Strict Standards: Declaration of Bulk_Plugin_Upgrader_Skin::before() should be compatible with that of Bulk_Upgrader_Skin::before() in /var/www/html/wp-admin/includes/class-wp-upgrader.php on line 1359 Strict Standards: Declaration of Bulk_Plugin_Upgrader_Skin::after() should be compatible with that of Bulk_Upgrader_Skin::after() in /var/www/html/wp-admin/includes/class-wp-upgrader.php on line 1359 Strict Standards: Declaration of Bulk_Theme_Upgrader_Skin::before() should be compatible with that of Bulk_Upgrader_Skin::before() in /var/www/html/wp-admin/includes/class-wp-upgrader.php on line 1394 Strict Standards: Declaration of Bulk_Theme_Upgrader_Skin::after() should be compatible with that of Bulk_Upgrader_Skin::after() in /var/www/html/wp-admin/includes/class-wp-upgrader.php on line 1394
Attachments (1)
Change History (7)
#1
@
13 years ago
- Component Upgrade/Install → Warnings/Notices
- Description modified (diff)
- Milestone Awaiting Review → 3.6
#3
follow-up:
↓ 4
@
13 years ago
Does Bulk_Upgrader_Skin also have to match the declarations of the above methods in WP_Upgrader_Skin?
#4
in reply to: ↑ 3
@
13 years ago
Replying to soulseekah:
Does
Bulk_Upgrader_Skinalso have to match the declarations of the above methods inWP_Upgrader_Skin?
Well, it doesn't produce the strict standards warning, so I guess we're good. As far as I can see, adding new optional arguments in overridden methods is fine, removing or changing existing arguments is not.
Note:
See TracTickets
for help on using tickets.
I believe this patch addresses the problem.