Post revision comparisons: Contrast issue

[esmi]

Not sure I’m comfortable with red-on-red and green-on-green when comparing 2 post revisions. At present, the background:foreground contrasts on both blocks (removed & added) are way too low at 2.7:1 (heck — even I’m having problems reading the texts). Please increase the text contrast/color so that it complies with the minimum 4.5:1 recommendation.

[esmi]

Forgot to mention - I'm using the MP6 plugin, so this ticket relates to the new UI viewed via this plugin.

[helen]

I doubt MP6 does anything to post revision colors, so I'm going to leave this open, but please only report issues using trunk with no plugins.

[bpetty]

I was going to look at bringing this subject up for 3.7 since I wanted to see if there was a chance of looking over the style and colors of the diffs in regard to accessibility.

It only caught my attention because MediaWiki recently (6 to 7 months ago) released a new version that addressed this in very high detail with their diffs mostly in the name of color-blind users.

Relevant discussions:

• ​https://bugzilla.wikimedia.org/show_bug.cgi?id=11374
• ​http://wikimedia.7.n6.nabble.com/RFC-Modifying-diff-colors-due-to-color-blindness-issues-td801040.html
• The final product: ​http://meta.wikimedia.org/wiki/Help:Diff

Though it's interesting to see that concerns about contrast didn't seem to be very important, just the hue.

Trac has had ​similar reports in the past as well (but never really did anything about it).

[SergeyBiryukov]

Appears to be related to the new revisions UI introduced in [23506] for #23497.

In 3.5, the diff text was black.

[adamsilverstein]

thanks for the reminder, the colors certainly need fixing! another suggestion for color issue was to use a texture as a highlight.

also discussed in ​Make WordPress Accessible... we plan to ask again and address this once the latest patches are committed.

[adamsilverstein]

thanks for these links. i like the final version where the color is applied to a box framing the changed line with a thick colored edge, makes sense that way.

Replying to bpetty:

I was going to look at bringing this subject up for 3.7 since I wanted to see if there was a chance of looking over the style and colors of the diffs in regard to accessibility.

It only caught my attention because MediaWiki recently (6 to 7 months ago) released a new version that addressed this in very high detail with their diffs mostly in the name of color-blind users.

Relevant discussions:

• ​https://bugzilla.wikimedia.org/show_bug.cgi?id=11374
• ​http://wikimedia.7.n6.nabble.com/RFC-Modifying-diff-colors-due-to-color-blindness-issues-td801040.html
• The final product: ​http://meta.wikimedia.org/wiki/Help:Diff

Though it's interesting to see that concerns about contrast didn't seem to be very important, just the hue.

Trac has had ​similar reports in the past as well (but never really did anything about it).

[nacin]

Time to act on this now that everything is in.

[esmi]

I doubt MP6 does anything to post revision colors

I'm sorry but I've just re-checked using 3.6-beta1-23930. With MP6 deactivated, the contrasts are just fine. With MP6 active, the contrasts are appallingly low. So this is a specific MP6 issue.

please only report issues using trunk with no plugins

I was specifically asked to post this issue in Trac when I mentioned it elsewhere. If that was incorrect, then I apologise but I'm sorta getting stuck between a rock and a hard place here. Also, I understood that MP6 was specifically designed for UI development. So if we don't report these issues here, where should they be reported?

[melchoyce]

esmi: You can report mp6-specific issues on our weekly updates posted on make.wordpress.org/ui. Here's the most recent update: ​http://make.wordpress.org/ui/2013/04/05/mp6-0-6/

Thanks!

Replying to esmi:

I was specifically asked to post this issue in Trac when I mentioned it elsewhere. If that was incorrect, then I apologise but I'm sorta getting stuck between a rock and a hard place here. Also, I understood that MP6 was specifically designed for UI development. So if we don't report these issues here, where should they be reported?

[nhuja]

I think the text should be black in color despite plugin or not.. It just looks better. We already have a background color to differentiate.

[SergeyBiryukov]

Related: #24038

[ocean90]

#24038 was marked as a duplicate.

[ocean90]

23810.patch​:

Before:

After:

23810.2.patch​ removes also the line-through which is IMO not needed. (Like in 3.5)

[ocean90]

In 23995:

Revisions UI: Increase the text contrast/color for the diffs. see #23810.

[SergeyBiryukov]

Per our ​CSS coding standards, #ffaaaa and #aaffaa can be shortened to #faa and #afa.

[helen]

In 24064:

CSS coding standards for [23995]. props SergeyBiryukov. see #23810.

[bpetty]

The really important changes in regards to this ticket were applied for 3.6 in r23995. I originally suggested this ticket stay open for my points outlined in comment:4 (as we can still probably do better), but a new ticket for that can just be opened in the future.