WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 23 months ago

Last modified 23 months ago

#23810 closed defect (bug) (fixed)

Post revision comparisons: Contrast issue

Reported by: esmi Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Accessibility Keywords: ui-feedback has-patch
Focuses: Cc:

Description

Not sure I’m comfortable with red-on-red and green-on-green when comparing 2 post revisions. At present, the background:foreground contrasts on both blocks (removed & added) are way too low at 2.7:1 (heck — even I’m having problems reading the texts). Please increase the text contrast/color so that it complies with the minimum 4.5:1 recommendation.

Attachments (4)

before.png (92.6 KB) - added by ocean90 2 years ago.
after.png (92.5 KB) - added by ocean90 2 years ago.
23810.patch (1.5 KB) - added by ocean90 2 years ago.
23810.2.patch (1.5 KB) - added by ocean90 2 years ago.

Download all attachments as: .zip

Change History (23)

comment:1 @esmi2 years ago

  • Summary changed from Post revision comparisons: Contrast isue to Post revision comparisons: Contrast issue

comment:2 @esmi2 years ago

Forgot to mention - I'm using the MP6 plugin, so this ticket relates to the new UI viewed via this plugin.

comment:3 @helen2 years ago

I doubt MP6 does anything to post revision colors, so I'm going to leave this open, but please only report issues using trunk with no plugins.

comment:4 follow-up: @bpetty2 years ago

  • Cc bpetty added

I was going to look at bringing this subject up for 3.7 since I wanted to see if there was a chance of looking over the style and colors of the diffs in regard to accessibility.

It only caught my attention because MediaWiki recently (6 to 7 months ago) released a new version that addressed this in very high detail with their diffs mostly in the name of color-blind users.

Relevant discussions:

Though it's interesting to see that concerns about contrast didn't seem to be very important, just the hue.

Trac has had similar reports in the past as well (but never really did anything about it).

comment:5 @SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.6

Appears to be related to the new revisions UI introduced in [23506] for #23497.

In 3.5, the diff text was black.

comment:6 @adamsilverstein2 years ago

thanks for the reminder, the colors certainly need fixing! another suggestion for color issue was to use a texture as a highlight.

also discussed in Make WordPress Accessible... we plan to ask again and address this once the latest patches are committed.

comment:7 in reply to: ↑ 4 @adamsilverstein2 years ago

thanks for these links. i like the final version where the color is applied to a box framing the changed line with a thick colored edge, makes sense that way.

Replying to bpetty:

I was going to look at bringing this subject up for 3.7 since I wanted to see if there was a chance of looking over the style and colors of the diffs in regard to accessibility.

It only caught my attention because MediaWiki recently (6 to 7 months ago) released a new version that addressed this in very high detail with their diffs mostly in the name of color-blind users.

Relevant discussions:

Though it's interesting to see that concerns about contrast didn't seem to be very important, just the hue.

Trac has had similar reports in the past as well (but never really did anything about it).

comment:8 @nacin2 years ago

Time to act on this now that everything is in.

comment:9 follow-up: @esmi2 years ago

I doubt MP6 does anything to post revision colors

I'm sorry but I've just re-checked using 3.6-beta1-23930. With MP6 deactivated, the contrasts are just fine. With MP6 active, the contrasts are appallingly low. So this is a specific MP6 issue.

please only report issues using trunk with no plugins

I was specifically asked to post this issue in Trac when I mentioned it elsewhere. If that was incorrect, then I apologise but I'm sorta getting stuck between a rock and a hard place here. Also, I understood that MP6 was specifically designed for UI development. So if we don't report these issues here, where should they be reported?

comment:10 in reply to: ↑ 9 @melchoyce2 years ago

esmi: You can report mp6-specific issues on our weekly updates posted on make.wordpress.org/ui. Here's the most recent update: http://make.wordpress.org/ui/2013/04/05/mp6-0-6/

Thanks!

Replying to esmi:

I was specifically asked to post this issue in Trac when I mentioned it elsewhere. If that was incorrect, then I apologise but I'm sorta getting stuck between a rock and a hard place here. Also, I understood that MP6 was specifically designed for UI development. So if we don't report these issues here, where should they be reported?

comment:11 @nhuja2 years ago

I think the text should be black in color despite plugin or not.. It just looks better. We already have a background color to differentiate.

comment:13 @ocean902 years ago

#24038 was marked as a duplicate.

@ocean902 years ago

@ocean902 years ago

@ocean902 years ago

@ocean902 years ago

comment:14 @ocean902 years ago

  • Keywords has-patch added

23810.patch:

Before:
https://core.trac.wordpress.org/raw-attachment/ticket/23810/before.png

After:
https://core.trac.wordpress.org/raw-attachment/ticket/23810/after.png

23810.2.patch removes also the line-through which is IMO not needed. (Like in 3.5)

comment:15 @ocean902 years ago

In 23995:

Revisions UI: Increase the text contrast/color for the diffs. see #23810.

comment:16 @ethitter2 years ago

  • Cc erick@… added

comment:17 @SergeyBiryukov2 years ago

Per our CSS coding standards, #ffaaaa and #aaffaa can be shortened to #faa and #afa.

comment:18 @helen2 years ago

In 24064:

CSS coding standards for [23995]. props SergeyBiryukov. see #23810.

comment:19 @bpetty23 months ago

  • Resolution set to fixed
  • Status changed from new to closed

The really important changes in regards to this ticket were applied for 3.6 in r24064. I originally suggested this ticket stay open for my points outlined in comment:4 (as we can still probably do better), but a new ticket for that can just be opened in the future.

Version 0, edited 23 months ago by bpetty (next)
Note: See TracTickets for help on using tickets.