XML-RPC shouldn't display errors

[koke]

I've got some user reports of XML-RPC returning this:

<b>Warning</b>
<a href='function.strpos'>function.strpos</a>
<b>
/home/www/simplythreemusic.com/wp-includes/class-wp-xmlrpc-server.php</b>

In this case, it seems to be #18310, but XML-RPC shouldn't be throwing any warnings, since that makes the client think the request failed when it actually succeeded

[markoheijnen]

Possible fix

[markoheijnen]

Moving to 3.6 for future discussions.

[SergeyBiryukov]

Related: #23017

[kovshenin]

23811.2.diff​ is similar to Marko's patch but for the WP_DEBUG_DISPLAY constant instead, which then sets display_errors.

[markoheijnen]

That doesn't exactly works the same. Your patch only works when WP_DEBUG is true and my one only works when WP_DEBUG is false.

I guess the issue here is that the server definition is display_errors: 1. So I guess both patches make sense to commit then?

[SergeyBiryukov]

23811.diff​ makes sense to me.

Not sure if WP_DEBUG_DISPLAY should default to false for XML-RPC. Should we do the same for AJAX in that case? I guess it should still default to true, otherwise it would make debugging harder.

[markjaquith]

once, after

[markjaquith]

In 24564:

Don't display errors for XML-RPC requests, as they malform the response.

fixes #23811. props kovshenin, markoheijnen.

[nacin]

In 24581:

Documentation for [24564]. see #23811.