WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#23813 closed defect (bug) (fixed)

3.6-Menus: Menu select should use get instead of post

Reported by: DrewAPicture Owned by: markjaquith
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Menus Keywords: 3.6-menus commit
Focuses: Cc:

Description (last modified by DrewAPicture)

@helen commented on ticket:23607:20:

Thinking the select a menu form should be get instead of post.

There's a patch on the tracking ticket: ticket:23607:23607.diff

Attachments (3)

23813.diff (792 bytes) - added by lessbloat 8 years ago.
23813.1.diff (739 bytes) - added by lessbloat 8 years ago.
23813.2.diff (1.8 KB) - added by helen 8 years ago.

Download all attachments as: .zip

Change History (12)

#1 @DrewAPicture
8 years ago

  • Description modified (diff)

@lessbloat
8 years ago

#2 @lessbloat
8 years ago

23813.diff​ should do it.

#3 @helen
8 years ago

Meant to mention that my reasoning for this is so that the URL changes (bookmarking, copying the link, just looking nice) and so that if the user refreshes for some reason after switching the menu it doesn't prompt them about re-submitting form data.

@lessbloat
8 years ago

#4 @lessbloat
8 years ago

  • Keywords commit has-patch added

23813.1.diff​ addresses Helen's second concern on ticket:23607:20.

@helen
8 years ago

#5 @helen
8 years ago

Looks like we use an empty action for forms around the admin rather than just omitting it. Also, there are more forms on the screen. Maybe 23813.2.diff?

#6 @lessbloat
8 years ago

23813.2.diff​ looks good to me. This is ready for commit.

#7 @markjaquith
8 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 23807:

Use GET for nav menu selection, and default action.

fixes #23813. props helen.

#8 @johnbillion
8 years ago

  • Keywords has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

This has had the side effect that after adding a new menu you remain on the new menu screen.

#9 @DrewAPicture
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in [23810]

Note: See TracTickets for help on using tickets.