Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#23830 closed enhancement (fixed)

Update to Backbone 1.0.0

Reported by: mattwiebe's profile mattwiebe Owned by: nacin's profile nacin
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: External Libraries Keywords:
Focuses: Cc:

Description

Backbone 1.0.0 was released today.

I've done a cursory test of the media modal and the current state of revisions and everything appears to be working fine.

Attachments (2)

backbone.diff (37.2 KB) - added by mattwiebe 11 years ago.
23830.diff (38.8 KB) - added by koopersmith 11 years ago.

Download all attachments as: .zip

Change History (13)

@mattwiebe
11 years ago

#1 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 3.6

#2 @SergeyBiryukov
11 years ago

  • Type changed from defect (bug) to enhancement

#3 @koopersmith
11 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

That's not the case — Collections were changed to fire "set" instead of "reset", which is causing a bunch of breakage. The patch doesn't bust the cache, so you were likely still seeing 0.9.10.

@koopersmith
11 years ago

#4 @koopersmith
11 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

This should get us most of the way there. I think there still may be a rough edge or two; please test and record what you find.

#5 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23893:

Backbone 1.0.0.

Update media JS to reflect changes. Please open new tickets for remaining issues.

props koopersmith.
fixes #23830.

#6 follow-up: @kovshenin
11 years ago

I tried to debug this, but seems like it's beyond my backbone skills. After the 1.0.0 update in [23893], the Attachments collection has always got one more element than it should, resulting in an weird empty element on all media screens: http://cl.ly/image/3x033D2i0H3t

#7 @kovshenin
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#8 @ocean90
11 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

#9 @adamsilverstein
11 years ago

  • Cc adamsilverstein@… added

#10 in reply to: ↑ 6 @SergeyBiryukov
11 years ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to kovshenin:

After the 1.0.0 update in [23893], the Attachments collection has always got one more element than it should, resulting in an weird empty element on all media screens: http://cl.ly/image/3x033D2i0H3t

Let's handle this in #24094.

#11 @markjaquith
11 years ago

In 24771:

Fix a media regression in [24110] that could cause duplicate models.

Props garyc40. Fixes #24753. See #24094, #23830.

Note: See TracTickets for help on using tickets.