Opened 11 years ago
Closed 11 years ago
#23843 closed enhancement (fixed)
Consolidate and filter get_attached_audio|video|images
Reported by: | helen | Owned by: | helen |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Media | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Seeing as they are so very similar, we should probably just de-spaghetti and consolidate them into get_attached_media( $type )
. Should also filter the args and the resulting arrays.
Attachments (2)
Change History (8)
#2
@
11 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
So my question is, do we even need the wrapper functions? These aren't template tags, so I'm inclined to think, maybe not.
#3
@
11 years ago
I disdain too much reflection, but I like those API funcs. Also, http://core.trac.wordpress.org/browser/trunk/wp-includes/post.php#L1701
#4
@
11 years ago
- Keywords 2nd-opinion added
In the spirit of reducing the absolute weight of functions we're adding in 3.6 (70+ at last count), I'm with @nacin on ditching the wrapper functions.
#5
@
11 years ago
- Keywords has-patch commit added; 2nd-opinion removed
Everyone out of the pool 23843.2.diff
Note: See
TracTickets for help on using
tickets.
In 23776: