Searchform Format

[WraithKenny]

We should use a filter instead of an argument.

[WraithKenny]

The advantage of a filter is themes wouldn't have to add args to each get_search_form call, and places where core calls it would be affected (which seems desirable), like (search widget), and would obsolete #23848

[lancewillett]

+1 -- cleaner and easier. In a theme, it'd be rare you'd want one search form call to be XHTML and another be HTML5.

[lancewillett]

@WraithKenny -- something's weird with your patch. Did not apply cleanly in my local WP install.

[SergeyBiryukov]

PHPDoc needs to be updated to reflect the change.

[SergeyBiryukov]

#23848 was marked as a duplicate.

[lancewillett]

See also #23701 (.2 patch).

[WraithKenny]

I created it from git unified diff, thought it'd be compatible... Making a new one, to include docs.

[WraithKenny]

New patch is good ol' fashioned svn patch. Just removed the @param doc (didn't need anything else, right?)

[DrewAPicture]

Replying to WraithKenny:

Just removed the @param doc (didn't need anything else, right?)

Edit: Yeah, didn't realize the $format param was introduced in the 3.6 cycle. Disregard 23850.diff​.

[WraithKenny]

The param was only there for 11 days, and we didn't hit beta with it. I don't think we should add the deprecated arg.

[DrewAPicture]

Replying to WraithKenny:

The param was only there for 11 days, and we didn't hit beta with it. I don't think we should add the deprecated arg.

Ha, good call. Didn't realize the param was added in this cycle. By all means general-template.php.patch​ should do the trick.

[SergeyBiryukov]

In 23798:

Use a filter instead of recently added $format argument in get_search_form(). props WraithKenny. fixes #23850. see #15081.

[lancewillett]

In 23799:

Twenty Thirteen: remove HTML5 argument for search form, using a filter instead. See #23850, closes #23701.

[azizur]

Replying to lancewillett:

Can we update the PHPDocs to highlight that search_form_format filter is 3.6 feature.

[nacin]

I'm not sure this should be a filter. Or rather, while it should be a filter, this should also be theme support. There's no reason to force a theme to write a function just to return 'html5' when a single add_theme_support() function will do.

[SergeyBiryukov]

23850.2.diff​ checks for html5-search-form theme feature.

[SergeyBiryukov]

Created #24269 for Twenty Thirteen.

[SergeyBiryukov]

In 24225:

Allow to switch get_search_form() to HTML5 with an add_theme_support() call. fixes #23850.

[nacin]

Thinking we should make a few more changes here.

[obenland]

I love the move to a simple 'html5' support call.

In .3.diff, can we make it 'comment-form' and 'search-form' maybe? We could use 'comments' or 'comment-list' for the html5 markup in wp_list_comments() then.

We also introduced html5 in the Quote format fallback, would it make sense to add a switch there, too? Happy to add a patch if you think we should, btw :)

[lancewillett]

Replying to obenland:

We also introduced html5 in the Quote format fallback, would it make sense to add a switch there, too? Happy to add a patch if you think we should, btw :)

I'd vote no switch to 3.6+ features because a) we don't need back compat and b) we're pushing the web forward to modern markup.

[obenland]

Like .4 but looking for 'search-form' support instead of 'search'

[nacin]

In 24417:

`add_theme_support( 'html5', array( 'comment-list', 'search-form', 'comment-form' ) );'

props obenland.
see #23850.

[lancewillett]

In 24421:

Twenty Thirteen: Remove twentythirteen_search_form_format() filter in favor of add_theme_support() call for search form, comment form, and comment list markup. Props SergeyBiryukov, fixes #24269; see #23850.

[obenland]

Adds .search-field class and hyphenates other classes in html5 output

[nacin]

In 24524:

Improve the HTML classes for the new html5 format in get_search_form().

Update Twenty Thirteen to reflect the changes.

props obenland.
fixes #23850.

[lancewillett]

In 24536:

Twenty Thirteen: update RTL styles to match changes in r24524, props obenland. See #23850.

[lancewillett]

In 24540:

Twenty Thirteen: update IE styles to match changes in r24524. See #23850.