Opened 12 years ago
Closed 12 years ago
#23852 closed defect (bug) (fixed)
Twenty Thirteen: add support for quote structured post format
Reported by: | obenland | Owned by: | lancewillett |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Bundled Theme | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description
With the switch to supporting structured post formats, Twenty Thirteen no longer gets to enjoy the heavenly cushions of post_format_compat()
.
Attachments (7)
Change History (22)
#2
@
12 years ago
- Keywords has-patch added
- Summary changed from Twenty Thirteen: Add support for structured post formats to Twenty Thirteen: add support for quote structured post format
Might be good to split out each post format into a new ticket. So quote, link, etc. (Instead of all here in one ticket.)
#3
@
12 years ago
- Keywords needs-refresh added
Discussing in today's IRC office hours, we are going to push the markup improvements to core, into the postpost_formats_compat()
function -- and trim the Twenty Thirteen patch here to just CSS support.
#4
@
12 years ago
- Keywords needs-refresh removed
See #23347 for the updated quote post format markup; http://core.trac.wordpress.org/attachment/ticket/23347/23347.10.diff is the relevant patch.
#7
@
12 years ago
- Keywords needs-refresh added
Looks like we still need styling for the figcaption
— since it replaces cite
.
#10
follow-up:
↓ 11
@
12 years ago
Can we use .quote-caption
instead of blockquote + figcaption
, .quote-caption figcaption
, and .entry-content figcaption
? I think it's simpler.
I'm sorry I didn't point that out before, I thought you wanted to globally style the figcaption element.
#11
in reply to:
↑ 10
@
12 years ago
Replying to obenland:
Can we use
.quote-caption
instead ofblockquote + figcaption
,.quote-caption figcaption
, and.entry-content figcaption
? I think it's simpler.
I'm sorry I didn't point that out before, I thought you wanted to globally style the figcaption element.
Yep, makes sense now.
#12
@
12 years ago
Thanks for the updated patch, testing again now with both structured and older post-content quotes.
#13
follow-up:
↓ 14
@
12 years ago
Turns out we can remove a bunch of stuff now with the new markup.
#14
in reply to:
↑ 13
@
12 years ago
Replying to obenland:
Turns out we can remove a bunch of stuff now with the new markup.
Right, but I think we should also support fallbacks to "normal" blockquotes and cites if people enter them into the post content.
Think of someone upgrading to 3.6 and Twenty Thirteen but with a bunch of older Quote post format posts.
I took inspiration for the quotes markup from this article.