WordPress.org

Make WordPress Core

#23852 closed defect (bug) (fixed)

Twenty Thirteen: add support for quote structured post format

Reported by: obenland Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: Cc:

Description

With the switch to supporting structured post formats, Twenty Thirteen no longer gets to enjoy the heavenly cushions of post_format_compat().

Attachments (7)

23852-quotes.diff (2.8 KB) - added by obenland 16 months ago.
23852.1.diff (663 bytes) - added by obenland 16 months ago.
23852.2.diff (1.2 KB) - added by lancewillett 16 months ago.
23852.3.diff (1.3 KB) - added by lancewillett 16 months ago.
23852.4.diff (1.1 KB) - added by obenland 16 months ago.
23852.5.diff (1.4 KB) - added by obenland 16 months ago.
23852.6.diff (1.2 KB) - added by obenland 16 months ago.

Download all attachments as: .zip

Change History (22)

obenland16 months ago

comment:1 obenland16 months ago

I took inspiration for the quotes markup from this article.

comment:2 lancewillett16 months ago

  • Keywords has-patch added
  • Summary changed from Twenty Thirteen: Add support for structured post formats to Twenty Thirteen: add support for quote structured post format

Might be good to split out each post format into a new ticket. So quote, link, etc. (Instead of all here in one ticket.)

comment:3 lancewillett16 months ago

  • Keywords needs-refresh added

Discussing in today's IRC office hours, we are going to push the markup improvements to core, into the postpost_formats_compat() function -- and trim the Twenty Thirteen patch here to just CSS support.

obenland16 months ago

comment:4 lancewillett16 months ago

  • Keywords needs-refresh removed

See #23347 for the updated quote post format markup; http://core.trac.wordpress.org/attachment/ticket/23347/23347.10.diff is the relevant patch.

comment:5 lancewillett16 months ago

In 23802:

Twenty Thirteen: add styles for default core output for structured quote post format. Depends on #23347 for the improved markup for quote post formats. Props obenland, see #23852.

comment:6 lancewillett16 months ago

In 23803:

Twenty Thirteen: explicitly declare 'link' and 'video' as the only (current) structured post formats in Twenty Thirteen. See #23852 #23619 #23864 and #23620.

comment:7 lancewillett16 months ago

  • Keywords needs-refresh added

Looks like we still need styling for the figcaption — since it replaces cite.

comment:8 lancewillett16 months ago

  • Keywords needs-testing added; needs-refresh removed

lancewillett16 months ago

lancewillett16 months ago

comment:9 lancewillett16 months ago

.3 patch is refreshed after feedback from Obenland.

comment:10 follow-up: obenland16 months ago

Can we use .quote-caption instead of blockquote + figcaption, .quote-caption figcaption, and .entry-content figcaption ? I think it's simpler.

I'm sorry I didn't point that out before, I thought you wanted to globally style the figcaption element.

comment:11 in reply to: ↑ 10 lancewillett16 months ago

Replying to obenland:

Can we use .quote-caption instead of blockquote + figcaption, .quote-caption figcaption, and .entry-content figcaption ? I think it's simpler.

I'm sorry I didn't point that out before, I thought you wanted to globally style the figcaption element.

Yep, makes sense now.

obenland16 months ago

comment:12 lancewillett16 months ago

Thanks for the updated patch, testing again now with both structured and older post-content quotes.

comment:13 follow-up: obenland16 months ago

Turns out we can remove a bunch of stuff now with the new markup.

comment:14 in reply to: ↑ 13 lancewillett16 months ago

Replying to obenland:

Turns out we can remove a bunch of stuff now with the new markup.

Right, but I think we should also support fallbacks to "normal" blockquotes and cites if people enter them into the post content.

Think of someone upgrading to 3.6 and Twenty Thirteen but with a bunch of older Quote post format posts.

obenland16 months ago

obenland16 months ago

comment:15 lancewillett16 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23829:

Twenty Thirteen: refresh Quote post format styles based on new default markup, see r23822. Props obenland, fixes #23852.

Note: See TracTickets for help on using tickets.