wp_enqueue_style does not properly handle URLs with a colon in the query parameters

[chengas123]

I have to call add_query_arg with the protocol:

add_query_arg( $query_args, "http://fonts.googleapis.com/css" )

However, I'd prefer to leave it off and believe that's generally the better practice:

add_query_arg( $query_args, "//fonts.googleapis.com/css" )

[obenland]

add_query_arg() does not force a protocol. In my tests it returned the above mentioned example just fine.

[chengas123]

You're right. Sorry, I misreported this bug originally. It's wp_enqueue_style that has a problem with styles that do not include a protocol.

I'm forced to do this:

wp_enqueue_style( 'twentytwelve-fonts', add_query_arg( $query_args, "$protocol://fonts.googleapis.com/css" ), array(), null );

When I would like to do this:

wp_enqueue_style( 'twentytwelve-fonts', add_query_arg( $query_args, "//fonts.googleapis.com/css" ), array(), null );

[obenland]

Support for relative urls in wp_enqueue_*() functions was added in r21166 for 3.5.

We define a protocol in Twenty Twelve for backwards compatibility with previous versions of WordPress.

[chengas123]

Hmm. I have 3.5.1 and it doesn't work for me when I try to custom edit the template. Maybe it's coming in a newer version of 3.5? In any case, thanks for the help.

[SergeyBiryukov]

Duplicate of #21974.

The issue here is not a relative URL by itself, it's a combination of a relative URL and a colon.

[chengas123]

Huh? What are you talking about? There's no colon in:

wp_enqueue_style( 'twentytwelve-fonts', add_query_arg( $query_args, "fonts.googleapis.com/css" ), array(), null );

Have I misunderstood?

[SergeyBiryukov]

What is the value of $query_args?

If you have copied it from Twenty Twelve, the family attribute has a colon in it:
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-content/themes/twentytwelve/functions.php#L135

[chengas123]

Ah, yes, I see. It should be able to handle that though! This is definitely a bug. Though obviously the title I reported it with is not accurate, so I have renamed it.

[chengas123]

Duplicate of #21974.

Sorry. I missed that you marked this as a duplicate