WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#23875 closed defect (bug)

Twenty Thirteen: improve jQuery code: remove deprecated functions, namespace events, and more — at Version 3

Reported by: obenland Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description (last modified by lancewillett)

  1. The syntax $(document).on("ready", handler) is deprecated as of jQuery 1.8.

It behaves similarly to the ready method but if the ready event has already fired and you try to .on("ready") the bound handler will not be executed. See: http://api.jquery.com/ready/

  1. We should namespace events: http://docs.jquery.com/Namespaced_Events
  1. The scroll event should be throttled for performance.

Change History (4)

@obenland2 years ago

comment:1 @lancewillett2 years ago

  • Priority changed from normal to low

I'm going to leave this 'til after beta, we can do some other general refactoring here.

comment:2 @nacin2 years ago

In 23891:

Don't use jQuery.on('ready'). props obenland. see #23875.

comment:3 @lancewillett2 years ago

  • Description modified (diff)
  • Keywords needs-refresh added
  • Priority changed from low to normal
  • Summary changed from Twenty Thirteen: Replace deprecated jQuery code to Twenty Thirteen: improve jQuery code: remove deprecated functions, namespace events, and more
Note: See TracTickets for help on using tickets.