WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#23886 closed defect (bug) (fixed)

Use set_url_scheme for draft Preview links in post table

Reported by: reidburke's profile reidburke Owned by: nacin's profile nacin
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

When using FORCE_SSL_ADMIN and this filter to prevent non-SSL preview of posts:

add_filter('secure_logged_in_cookie', '__return_true');

Preview links for unpublished drafts on wp-admin/edit.php do not use SSL and will 404.

This can be fixed by using set_url_scheme for the unpublished preview link. A similar unpublished preview link in meta-boxes.php was changed to use set_url_scheme in [21664]. For context, see #20759, #13328.

Attachments (1)

fix_ssl_post_lists_preview.diff​ (1.2 KB) - added by reidburke 10 years ago.
Proposed patch for Preview link in post table

Download all attachments as: .zip

Change History (6)

@reidburke
10 years ago

Proposed patch for Preview link in post table

#1 @reidburke
10 years ago

  • Keywords has-patch added

#2 @markjaquith
10 years ago

  • Milestone changed from Awaiting Review to Future Release

#3 @markjaquith
10 years ago

  • Milestone changed from Future Release to 3.6

Actually, pulling this into 3.6, as it's straightforward.

#4 @markjaquith
10 years ago

  • Keywords commit added

Still applies. Good to go.

#5 @nacin
10 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24780:

Do set_url_scheme() for Preview action link in the posts list table. props reidburke, fixes #23886.

Note: See TracTickets for help on using tickets.