WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 9 months ago

#23886 closed defect (bug) (fixed)

Use set_url_scheme for draft Preview links in post table

Reported by: reidburke Owned by: nacin
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

When using FORCE_SSL_ADMIN and this filter to prevent non-SSL preview of posts:

add_filter('secure_logged_in_cookie', '__return_true');

Preview links for unpublished drafts on wp-admin/edit.php do not use SSL and will 404.

This can be fixed by using set_url_scheme for the unpublished preview link. A similar unpublished preview link in meta-boxes.php was changed to use set_url_scheme in [21664]. For context, see #20759, #13328.

Attachments (1)

fix_ssl_post_lists_preview.diff (1.2 KB) - added by reidburke 13 months ago.
Proposed patch for Preview link in post table

Download all attachments as: .zip

Change History (6)

reidburke13 months ago

Proposed patch for Preview link in post table

comment:1 reidburke13 months ago

  • Keywords has-patch added

comment:2 markjaquith9 months ago

  • Milestone changed from Awaiting Review to Future Release

comment:3 markjaquith9 months ago

  • Milestone changed from Future Release to 3.6

Actually, pulling this into 3.6, as it's straightforward.

comment:4 markjaquith9 months ago

  • Keywords commit added

Still applies. Good to go.

comment:5 nacin9 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24780:

Do set_url_scheme() for Preview action link in the posts list table. props reidburke, fixes #23886.

Note: See TracTickets for help on using tickets.