WordPress.org

Make WordPress Core

#23888 closed defect (bug) (fixed)

Images in articles with post format "image" not displayed in Twenty Eleven, Twenty Ten

Reported by: nickbohle Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: blocker Version: 3.6
Component: Post Formats Keywords: has-patch commit
Focuses: Cc:

Description

Hi all,

yesterday, I've updated my website from r237XX to r23815. Since then, images in articles with post format "image" are not displayed.

I'm running my site with a simple child theme of Twenty Eleven. I've also experienced this behavior with Twenty Eleven and Twenty Ten.

Strangely, the image is displayed in Twenty Thirteen. See attached image.

I've just updated to WordPress 3.6-alpha-23833. Same bug...

Attachments (4)

post-format-image.jpg (67.0 KB) - added by nickbohle 16 months ago.
23888.diff (869 bytes) - added by wonderboymusic 16 months ago.
23888.2.diff (732 bytes) - added by SergeyBiryukov 16 months ago.
23888.3.diff (1.1 KB) - added by SergeyBiryukov 16 months ago.

Download all attachments as: .zip

Change History (11)

comment:1 wonderboymusic16 months ago

  • Milestone changed from Awaiting Review to 3.6
  • Severity changed from normal to blocker

I think this is a by-ref issue that I fixed elsewhere but not for images, will patch in a bit

comment:2 SergeyBiryukov16 months ago

  • Component changed from Themes to Post Formats

wonderboymusic16 months ago

comment:3 follow-up: wonderboymusic16 months ago

  • Keywords has-patch commit added

attachment:23888.diff Copy post field, don't reference directly

comment:4 in reply to: ↑ 3 nickbohle16 months ago

Replying to wonderboymusic:

attachment:23888.diff Copy post field, don't reference directly

Tested the patch on my install... Works fine for me. Image posts are displayed correctly again...

comment:6 aaroncampbell16 months ago

  • Cc aaroncampbell added

SergeyBiryukov16 months ago

SergeyBiryukov16 months ago

comment:7 SergeyBiryukov16 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23869:

Make a copy of post content to avoid changing it in get_the_image(). Remove unnecessary assignment from get_the_media(). props wonderboymusic for initial patch. fixes #23888.

Note: See TracTickets for help on using tickets.