#23890 closed enhancement (fixed)
Add slideUP/slideDown transitions to the menus accordion
Reported by: | DrewAPicture | Owned by: | helen |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Customize | Keywords: | has-patch |
Focuses: | Cc: |
Attachments (3)
Change History (17)
#5
@
12 years ago
- Cc pragunbhutani added
There's this one solution I'm uploading, but I'm not sure it's a good one.
Basically, the slide toggle was acting jumpy because of margin and border values. Similar to this problem.
I've added .slide-helper and .margin0 classes as a workaround because I didn't want to mess with existing classes for the fear of breaking something.
#6
@
12 years ago
- Keywords has-patch added
23890.2.diff adds sliding to accordion.js. This should cover both the menus UI as well as the customizer.
#7
@
12 years ago
It seems I've added my patch based on the code of version 3.5.1!
I realized this when I was trying to apply kovshevin's 23890.2.diff and couldn't find accordion.js
What becomes of my patch now?
#8
@
12 years ago
23890.2.diff works well for me, see here: http://screencast.com/t/vNbyJnQh1KYW
#9
follow-up:
↓ 10
@
12 years ago
The screencast indicates the animation here is way too slow. Needs to be snappier. But larger point: Is this necessary?
#10
in reply to:
↑ 9
@
12 years ago
Replying to nacin:
The screencast indicates the animation here is way too slow. Needs to be snappier. But larger point: Is this necessary?
Seems to me this would add just a teensy bit of polish and remove the jarring switch from box to box. A quick audit of other slideUp/slideDown
usage in core shows 'fast'
as the standard speed.
23890.3.diff adjusted to fast
: http://screencast.com/t/GWIDrOkO
Without animation: http://screencast.com/t/0J5vrL2SPQt
#11
@
12 years ago
I find it much easier to reorient myself with the animation. Definitely fast, though.
In 23856: