WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 9 months ago

#23890 closed enhancement (fixed)

Add slideUP/slideDown transitions to the menus accordion

Reported by: DrewAPicture Owned by: helen
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Appearance Keywords: has-patch
Focuses: Cc:

Description

We talked about this early in the cycle in #23119 and other places, but it would be nice to not make switching between accordion sections so jarring.

A slideUP/slideDown transition similar to how we're handling post formats in #19570 would be a nice UX addition.

Attachments (3)

23890.diff (1.5 KB) - added by pragunbhutani 12 months ago.
23890.2.diff (1.4 KB) - added by kovshenin 12 months ago.
23890.3.diff (1.5 KB) - added by DrewAPicture 9 months ago.
fast

Download all attachments as: .zip

Change History (15)

comment:1 DrewAPicture13 months ago

  • Type changed from defect (bug) to enhancement

comment:2 markjaquith13 months ago

In 23856:

Use jQuery.on() properly in accordion code. Some other cleanup.

see #23890.

comment:3 markjaquith13 months ago

Doing some other cleanups here while I'm in it.

comment:4 markjaquith13 months ago

In 23858:

Simplify the accordion sibling-section-closing JS.

see #23890

comment:5 pragunbhutani12 months ago

  • Cc pragunbhutani added

There's this one solution I'm uploading, but I'm not sure it's a good one.

Basically, the slide toggle was acting jumpy because of margin and border values. Similar to this problem.

I've added .slide-helper and .margin0 classes as a workaround because I didn't want to mess with existing classes for the fear of breaking something.

pragunbhutani12 months ago

kovshenin12 months ago

comment:6 kovshenin12 months ago

  • Keywords has-patch added

23890.2.diff adds sliding to accordion.js. This should cover both the menus UI as well as the customizer.

comment:7 pragunbhutani12 months ago

It seems I've added my patch based on the code of version 3.5.1!
I realized this when I was trying to apply kovshevin's 23890.2.diff and couldn't find accordion.js

What becomes of my patch now?

comment:8 DrewAPicture12 months ago

Version 0, edited 12 months ago by DrewAPicture (next)

comment:9 follow-up: nacin10 months ago

The screencast indicates the animation here is way too slow. Needs to be snappier. But larger point: Is this necessary?

DrewAPicture9 months ago

fast

comment:10 in reply to: ↑ 9 DrewAPicture9 months ago

Replying to nacin:

The screencast indicates the animation here is way too slow. Needs to be snappier. But larger point: Is this necessary?

Seems to me this would add just a teensy bit of polish and remove the jarring switch from box to box. A quick audit of other slideUp/slideDown usage in core shows 'fast' as the standard speed.

23890.3.diff adjusted to fast: http://screencast.com/t/GWIDrOkO

Without animation: http://screencast.com/t/0J5vrL2SPQt

comment:11 helen9 months ago

I find it much easier to reorient myself with the animation. Definitely fast, though.

comment:12 helen9 months ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 24644:

Add sliding animations to the accordion. props kovshenin, DrewAPicture, helen. fixes #23890.

Note: See TracTickets for help on using tickets.