Opened 12 years ago
Last modified 7 years ago
#23895 reviewing defect (bug)
Max upload size 0 when post_max_size = 0
Reported by: | moscar09 | Owned by: | johnbillion |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | 3.5.1 |
Component: | Upload | Keywords: | has-patch has-unit-tests dev-feedback |
Focuses: | Cc: |
Description (last modified by )
As a convention, post_max_size can be set to 0 to disable any limitation on max post size.
Quote from php.ini:
; Maximum size of POST data that PHP will accept. ; Its value may be 0 to disable the limit. It is ignored if POST data reading ; is disabled through enable_post_data_reading. ; http://php.net/post-max-size
WordPress does not take this into account in wp-admin/includes/template.php
Attachments (5)
Change History (15)
#3
@
11 years ago
It's worth noting that memory_limit
can also affect file uploading:
http://php.net/manual/en/ini.core.php#ini.post-max-size
This ticket was mentioned in IRC in #wordpress-dev by SergeyBiryukov. View the logs.
11 years ago
@
9 years ago
Properly determine the file size if one of the values, checked in the function is zero, meaning unlimited.
@
9 years ago
Added proper check for the optional parameters values. It would've failed with zero inputs.
@
9 years ago
Previous tests didn't catch the problem because the values that I tested with were too small
#26918 was marked as a duplicate.