Revisions UI: RTL support

[ocean90]

Current state: ​http://cl.ly/NwT1

• Left and right needs to be swapped
• Todos: ​http://core.trac.wordpress.org/browser/trunk/wp-admin/revision.php#L82

[DrewAPicture]

First-pass.

[DrewAPicture]

23897.diff​ is a first pass on fixing floats. I didn't touch the translatable strings yet. With this patch:

Also, I'd argue that it's not worth it/possible/realistic to change directions in the UI in terms of Previous/Next in the comparison view.

[DrewAPicture]

adds some context

[DrewAPicture]

23897.2.diff​ takes a stab at adding some context, also combined two strings into one.

EDIT: Disregard this patch and carry on from 23897.diff per comment:4

On a side note we should really fix the id selectors and class names in revision.php to bring them more in line with recommendations in the ​CSS Coding Standards. Selectors like removedandadded, backbonerevisionsinteract, etc aren't going to cut it.

[ocean90]

The string will be handled in #23901. So use this ticket only for the CSS parts.

On a side note we should really fix the id selectors and class names in revision.php

Definitely! But after the main things works. And in a separated ticket.

[SergeyBiryukov]

Replying to DrewAPicture:

On a side note we should really fix the id selectors and class names in revision.php

Also mentioned in ticket:23497:139.

[ocean90]

23897.3.patch​ includes the CSS part. Still needs the slider swap, which needs to be done in JS.

[adamsilverstein]

Replying to ocean90:

23897.3.patch​ includes the CSS part. Still needs the slider swap, which needs to be done in JS.

do you mean reversing the order of the slider ticks? how can JS determine if using RTL?

[adamsilverstein]

23897.3.diff​​

• includes previous css updates
• reverses direction of revisions in single handle mode. two handle mode was more complicated so i left it out for now, mulling, single handled mode was a simple solution

[adamsilverstein]

reverses direction for RTL in single handle mode

[adamsilverstein]

23897.4.diff​:

• completes RTL functionality in two handled mode
• adds additional inline documentation

two handle mode was a little trickier - in addition to reversing the handles, the values from the handle needed to be reversed; finally some of the logic when switching from single to two handled mode needed updating. in my testing i now see the same data results in RTL or non RTL mode.

[adamsilverstein]

completes RTL revisions functionality, add inline docs

[adamsilverstein]

complete RTL support

[adamsilverstein]

23897.5.diff​ -

• completes RTL support
• ajax-actions updates so only required diffs generated including in RTL mode

[adamsilverstein]

update against trunk

[adamsilverstein]

update against trunk

[adamsilverstein]

inline doc updates

[adamsilverstein]

add/complete css

[ocean90]

The text on the next/prev buttons needs to be swapped.

[ocean90]

Swap next/prev functionality

[adamsilverstein]

Replying to ocean90:

The text on the next/prev buttons needs to be swapped.

23897.10.diff​ looks good

[ocean90]

In 24205:

Revisions UI: RTL support. (And inline docs.)

props DrewAPicture, adamsilverstein. fixes #23897.