WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#23897 closed defect (bug) (fixed)

Revisions UI: RTL support

Reported by: ocean90 Owned by: ocean90
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Revisions Keywords: has-patch
Focuses: Cc:

Description

Attachments (11)

23897.diff (743 bytes) - added by DrewAPicture 2 years ago.
First-pass.
23897.2.diff (3.6 KB) - added by DrewAPicture 2 years ago.
adds some context
23897.3.patch (1.5 KB) - added by ocean90 2 years ago.
23897.3.diff (2.7 KB) - added by adamsilverstein 2 years ago.
reverses direction for RTL in single handle mode
23897.4.diff (12.7 KB) - added by adamsilverstein 2 years ago.
completes RTL revisions functionality, add inline docs
23897.5.diff (13.2 KB) - added by adamsilverstein 2 years ago.
complete RTL support
23897.6.diff (13.1 KB) - added by adamsilverstein 2 years ago.
update against trunk
23897.7.diff (13.1 KB) - added by adamsilverstein 2 years ago.
update against trunk
23897.8.diff (13.3 KB) - added by adamsilverstein 2 years ago.
inline doc updates
23897.9.diff (17.8 KB) - added by adamsilverstein 2 years ago.
add/complete css
23897.10.diff (18.6 KB) - added by ocean90 2 years ago.
Swap next/prev functionality

Download all attachments as: .zip

Change History (26)

@DrewAPicture2 years ago

First-pass.

comment:1 @DrewAPicture2 years ago

  • Keywords has-patch added; needs-patch removed

23897.diff is a first pass on fixing floats. I didn't touch the translatable strings yet. With this patch:

http://f.cl.ly/items/3w113R2P0D0y1Z1d2x1J/Screen%20Shot%202013-03-29%20at%206.18.30%20PM.png

Also, I'd argue that it's not worth it/possible/realistic to change directions in the UI in terms of Previous/Next in the comparison view.

@DrewAPicture2 years ago

adds some context

comment:2 follow-up: @DrewAPicture2 years ago

23897.2.diff takes a stab at adding some context, also combined two strings into one.

EDIT: Disregard this patch and carry on from 23897.diff per comment:4

On a side note we should really fix the id selectors and class names in revision.php to bring them more in line with recommendations in the CSS Coding Standards. Selectors like removedandadded, backbonerevisionsinteract, etc aren't going to cut it.

Last edited 2 years ago by DrewAPicture (previous) (diff)

comment:3 @DrewAPicture2 years ago

  • Cc xoodrew@… added

comment:4 @ocean902 years ago

The string will be handled in #23901. So use this ticket only for the CSS parts.

On a side note we should really fix the id selectors and class names in revision.php

Definitely! But after the main things works. And in a separated ticket.

comment:5 in reply to: ↑ 2 @SergeyBiryukov2 years ago

Replying to DrewAPicture:

On a side note we should really fix the id selectors and class names in revision.php

Also mentioned in ticket:23497:139.

@ocean902 years ago

comment:6 follow-up: @ocean902 years ago

23897.3.patch includes the CSS part. Still needs the slider swap, which needs to be done in JS.

comment:7 in reply to: ↑ 6 @adamsilverstein2 years ago

  • Cc adamsilverstein@… added

Replying to ocean90:

23897.3.patch includes the CSS part. Still needs the slider swap, which needs to be done in JS.

do you mean reversing the order of the slider ticks? how can JS determine if using RTL?

comment:8 @adamsilverstein2 years ago

23897.3.diff​

  • includes previous css updates
  • reverses direction of revisions in single handle mode. two handle mode was more complicated so i left it out for now, mulling, single handled mode was a simple solution

@adamsilverstein2 years ago

reverses direction for RTL in single handle mode

comment:9 @adamsilverstein2 years ago

  • Keywords dev-feedback added

23897.4.diff:

  • completes RTL functionality in two handled mode
  • adds additional inline documentation

two handle mode was a little trickier - in addition to reversing the handles, the values from the handle needed to be reversed; finally some of the logic when switching from single to two handled mode needed updating. in my testing i now see the same data results in RTL or non RTL mode.

@adamsilverstein2 years ago

completes RTL revisions functionality, add inline docs

@adamsilverstein2 years ago

complete RTL support

comment:10 @adamsilverstein2 years ago

23897.5.diff -

  • completes RTL support
  • ajax-actions updates so only required diffs generated including in RTL mode

comment:11 @ocean902 years ago

  • Keywords needs-refresh added; dev-feedback removed

@adamsilverstein2 years ago

update against trunk

@adamsilverstein2 years ago

update against trunk

comment:12 @DrewAPicture2 years ago

  • Keywords needs-refresh removed

@adamsilverstein2 years ago

inline doc updates

@adamsilverstein2 years ago

add/complete css

comment:13 follow-up: @ocean902 years ago

The text on the next/prev buttons needs to be swapped.

@ocean902 years ago

Swap next/prev functionality

comment:14 in reply to: ↑ 13 @adamsilverstein2 years ago

Replying to ocean90:

The text on the next/prev buttons needs to be swapped.

23897.10.diff​ looks good

comment:15 @ocean902 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 24205:

Revisions UI: RTL support. (And inline docs.)

props DrewAPicture, adamsilverstein. fixes #23897.

Note: See TracTickets for help on using tickets.