Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#23917 closed defect (bug) (fixed)

Revisions UI: Add translation context

Reported by: nao's profile nao Owned by: ocean90's profile ocean90
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Revisions Keywords: has-patch
Focuses: Cc:

Description

Some generic strings ("From:", "To:", "Previous", "Next") appear on the new Revisions UI. To keep these separate from other admin labels, translation context is needed.

For example, "Next" can mean "Next Page" but it's better to be translated differently than "Next Revision".

Attachments (3)

revision-i18n.diff (2.1 KB) - added by nao 11 years ago.
Adds translation context to Revisions UI.
23917.patch (4.6 KB) - added by ocean90 11 years ago.
23917.2.patch (5.3 KB) - added by ocean90 11 years ago.

Download all attachments as: .zip

Change History (7)

@nao
11 years ago

Adds translation context to Revisions UI.

#1 @ocean90
11 years ago

  • Milestone changed from Awaiting Review to 3.6
  • Severity changed from trivial to normal

From and To will be handled in #23901.

@ocean90
11 years ago

#2 follow-up: @ocean90
11 years ago

  • Cc adamsilverstein added

23917.patch refreshes patch from nao. It removes also the l10n part from the JS cleanup since it's unused.

Seems like we can also remove the #diff-title-from-current-version section. @adamsilverstein, can you confirm it?

#3 in reply to: ↑ 2 @adamsilverstein
11 years ago

Replying to ocean90:

23917.patch refreshes patch from nao. It removes also the l10n part from the JS cleanup since it's unused.

Seems like we can also remove the #diff-title-from-current-version section. @adamsilverstein, can you confirm it?

yes, i believe #diff-title-from-current-version can be removed

@ocean90
11 years ago

#4 @ocean90
11 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 24157:

Revisions UI: Add translation contexts and remove unneeded lines.

props nao. fixes #23917.

Note: See TracTickets for help on using tickets.