Support for remove_post_type_support() in attachment post type

[flyingtrolleycars]

In the past it was possible to remove certain fields from the media editor by hooking "attachment_fields_to_edit" and unset'ing the fields you didn't want included (e.g. caption).

After the media library got the major rework in WP3.5 its longer possible to remove those fields.

I believe that since the attachment post type has been more closely lined up to normal posts it should support remove_post_type_support() et al.

The easiest (and probably popular) case for this is removing the editor. I believe this code should do the trick:

remove_post_type_support( 'attachment', 'editor' );

[mordauk]

I'd love to see this. I'd think that removing support for "caption", for example, would remove the caption field both from the media modal and also the edit media screen.

[ericlewis]

Caption maps to post_excerpt, Description maps to post_content, the remove_post_type_support() calls should respect that.

remove_post_type_support( 'attachment', 'title' ) works properly for the Edit Media screen, but not in the modal.

Alt text is saved as post meta under the _wp_attachment_image_alt key, so that can't be disabled via the same mechanism.

Needs patch.

[antpb]

In posts.php the array was not registering 'caption' for global $_wp_post_type_features;

This includes caption into the array

		'supports' => array( 'title', 'author', 'comments', 'caption' ),

The media panel is not determining to show it based on the array. Continuing to look into where that is linked.

[Solvitor]

Fun pair programming at #wcsf14. @antpb will push it over the line!

[antpb]

First pass. Worked with Solvitor on this one so please share the credit!

We added 'alt' 'description' and 'caption' to the array that links up.

[antpb]

Patch for remove_post_type_support() in attachment post type

[antpb]

Found Bug, fixed and resubmitting patch.

[antpb]

Noticed that the embed edit image panel was overlooked and revised media-template.php to omit captions and alt text if defined with remove_post_type_support

Adding updated patch.

[antpb]

Noticed unnecessary comment in closing of if statement. Revised patch to follow.

[antpb]

Patch updated

[wonderboymusic]

There is code in the theme that shouldn't be in the patch.

[antpb]

Replying to wonderboymusic:

There is code in the theme that shouldn't be in the patch.

Removed theme code from patch. Here's the update.

[antpb]

Patch update to remove theme changes

[antpb]

As per Nacin's suggestion I have removed all of the post supports except title as it is the only one that is already registered as reported and may have the need to be removed. I have tested this and it seems to be working fine when adding the removal of the title post type and also without the removal.

[nacin]

It doesn't look like there is much of a demand for this, so I suggested to @antpb that we simply fix this for 'title', since it's an existing supports argument.

Adding new 'supports' arguments is a bit tenuous, and has gotten us to consider things like a separate 'disables' flag. (This came up with #21391 and elsewhere, but hasn't had a real need yet.)

In this case, I don't see a major reason to disable other fields, though. And if you needed to, you could still hide or remove them via JS or PHP. There's also the old disable_captions filter we kept around after 3.5.

Committing 23932-6.patch​.

[nacin]

In 32773:

Media: Support title fields to be removed from attachments.

props antpb.
fixes #23932.