Make WordPress Core

Opened 5 years ago

Last modified 5 years ago

#23935 closed enhancement

Revision UI cleanup / improvements / corrections — at Version 7

Reported by: adamsilverstein Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Revisions Keywords:
Focuses: Cc:

Description (last modified by ocean90)

The new revisions UI still needs some UI polish. Now that we have addressed code/functionality issues i thought i would open a ticket to note the outstanding visual issues not addressed elsewhere:

  • the tooltips need work: their placement varies by browser, also it would be ideal if the tooltip stayed open while a user dragged the handle - currently the tooltip only stays open and updates if you keep your mouse confined to the slider handle; the slider on the other hand works fine if you drag and keep dragging but don't stay in the handle with your mouse; the result is that if you move off the handle while dragging, the slider moves, but the tooltip disappears.
  • the weighted tick marks get off to the left of center when they get thicker because of the way they are implemented; should fix so they are more accurately centered under the slider handle; last tick mark missing in compare two mode?
  • the slider handle graphics are currently encoded as base 64 in the css, not certain thats the best way to implement them
  • the 'compare two mode' option placement in the upper right seems haphazard, its just floating out there; also we lost the 'single column' option for the diff view - not sure if we still want it, but i liked it.
  • with just a few revisions the slider/next/previous seem disconnected; with over a certain number of revisions the slider will grow wider than the screen; #24056

Change History (9)

#1 @ocean90
5 years ago

  • Keywords needs-ui added
  • Milestone changed from Awaiting Review to 3.6
  • Version changed from 3.5.1 to trunk

5 years ago

#2 @bpetty
5 years ago

Maybe I'm the only one that thinks this, but it just seems like a terrible idea for the title and excerpt content to be prepended and appended (respectively) right inline with the actual post content in the diff. The diff currently makes you think the new title and excerpt was accidentally included right in the post content.

I understand that it's nice to be able to see those changes along with the post content, but I really think those need to be in their own sections if they are going to be included.

So currently it looks like this:

But it should probably look more like this:


old title => new title


first post => second post


old excerpt => new excerpt

#3 @bpetty
5 years ago

  • Cc bpetty added

I should note that it's actually even worse when you go from no title/excerpt to a new one since there isn't even a "removed" line for it, so it definitely looks like it was just added to the main post content.

#4 @bpetty
5 years ago

Related: #23899

#5 @ocean90
5 years ago

Related: #24056

#6 @ocean90
5 years ago

bpetty's point is handled in #23903.

#7 @ocean90
5 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.