WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#23937 closed defect (bug) (fixed)

"Restore This Revision" button redirects to /wp-admin/null

Reported by: mgibbs189 Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Revisions Keywords: has-patch commit
Focuses: Cc:

Description

Steps to reproduce:

  1. Create a new page
  2. Make content edits several times (save each time)
  3. Click on a revision link within the Revisions meta box
  4. Click on the "Restore This Revision" button

Attachments (1)

23937.patch (391 bytes) - added by ocean90 2 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 @ocean902 years ago

  • Keywords has-patch added; dev-feedback removed
  • Milestone changed from Awaiting Review to 3.6

@ocean902 years ago

comment:2 @mgibbs1892 years ago

#23937 doesn't solve the whole problem. The restore() view doesn't seem to be getting triggered at all.

comment:3 @ocean902 years ago

Then I neeed some more infos. Which browser, OS? Any plugins enabled, SCRIPT_DEBUG is true?

Edit:
If it doesn't trigger, then you shouldn't have been redirected.

Last edited 2 years ago by ocean90 (previous) (diff)

comment:4 @mgibbs1892 years ago

The patch works correctly only when SCRIPT_DEBUG is true.

No plugins, latest Chrome, WP trunk, Win7.

comment:5 @ocean902 years ago

  • Keywords commit added

The patch works correctly only when SCRIPT_DEBUG is true.

And that's okay. The minified version will be generated when the patch lands in.

comment:6 @mgibbs1892 years ago

Ah, didn't realize that SCRIPT_DEBUG toggles .min -- my bad :)

comment:7 @mgibbs1892 years ago

  • Resolution set to fixed
  • Status changed from new to closed

[deleted]

Last edited 2 years ago by mgibbs189 (previous) (diff)

comment:8 @ocean902 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Tickets are marked as fixed when a changeset is commited to trunk which fixes the issue.

comment:9 @SergeyBiryukov2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from reopened to closed

In 23909:

Use correct id attribute. props ocean90. fixes #23937.

Note: See TracTickets for help on using tickets.