Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23947 closed defect (bug) (invalid)

Twenty Thirteen: Chats not displaying correctly

Reported by: ipstenu's profile Ipstenu Owned by:
Milestone: Priority: low
Severity: normal Version: 3.6
Component: Bundled Theme Keywords:
Focuses: Cc:

Description (last modified by johnbillion)

Reported by -

Basically the original twentythirteen showed chats like this:

speaker: blah blah blah

But now it's like this:

blah blah blah

ALSO if your speaker has two names, it totally barfs.

I copied the text from here:

to my site running the latest SVN and got this:

Change History (11)

#1 @SergeyBiryukov
10 years ago

  • Component changed from Themes to Bundled Theme

#2 @johnbillion
10 years ago

  • Description modified (diff)

#3 @SergeyBiryukov
10 years ago

  • Summary changed from TwentyThirteen: Chats not displaying correctly to Twenty Thirteen: Chats not displaying correctly

#4 @lancewillett
10 years ago

The demo site *is not* up to date with Post Formats, so please don't use it as a rubric until we merge 3.6 beta there.

The two-line display is intentional, see #23869 for how it is intended to look.

@ipstenu Can you paste here the chat text to test with for the two names issue?

#5 @lancewillett
10 years ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to 3.6
  • Priority changed from normal to low
  • Severity changed from major to normal

#6 @Ipstenu
10 years ago

  • Keywords reporter-feedback removed

@lancewillet - Good to know!

The chat text I used was this:

Nigel Tufnel: The numbers all go to eleven. Look, right across the board, eleven, eleven, eleven and…

Marti DiBergi: Oh, I see. And most amps go up to ten?

Nigel Tufnel: Exactly.

Marti DiBergi: Does that mean it’s louder? Is it any louder?

Nigel Tufnel: Well, it’s one louder, isn’t it? It’s not ten. You see, most blokes, you know, will be playing at ten. You’re on ten here, all the way up, all the way up, all the way up, you’re on ten on your guitar. Where can you go from there? Where?

Marti DiBergi: I don’t know.

Nigel Tufnel: Nowhere. Exactly. What we do is, if we need that extra push over the cliff, you know what we do?

Marti DiBergi: Put it up to eleven.

Nigel Tufnel: Eleven. Exactly. One louder.

Marti DiBergi: Why don’t you just make ten louder and make ten be the top number and make that a little louder?

Nigel Tufnel: These go to eleven.

I just pasted that in direct into plain HTML editor and it comes out blank. If I merge the names into one-word, then they show.

#7 @lancewillett
10 years ago

Thanks—I can repeat it in trunk, too.

Just to be clear though, this isn't theme-related. Twenty Thirteen only styles the core HTML output.

Best to raise the issue on the core chat post format ticket instead: #23625.

#8 @wonderboymusic
10 years ago

It wouldn't be the worst thing in the world if 23625-tests.diff​ got committed to Unit Tests since 1) I wrote them weeks ago and 2) that exact chat is one of the assertions

The tests were passing when the original code was committed, not sure what if anything got borked in subsequent commits

#9 @Ipstenu
10 years ago

  • Keywords close added

Thanks, lance. I wasn't sure if it was theme or core at that point (should have tested on more). Posted there.

We can close this :)

#10 @Ipstenu
10 years ago

  • Resolution set to invalid
  • Status changed from new to closed

#11 @SergeyBiryukov
10 years ago

  • Keywords close removed
  • Milestone 3.6 deleted
Note: See TracTickets for help on using tickets.