WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#23952 closed defect (bug) (wontfix)

Markup improvements to wp-admin/file.php and wp-admin/media.php

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by:
Milestone: Priority: low
Severity: minor Version:
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

  • Two text/javascript blocks are missing CDATA helpers.
  • file.php has a div within a th, which is not valid markup.

Attached patch fixes these up.

Attachments (1)

23952.patch​ (1.8 KB) - added by johnjamesjacoby 12 years ago.

Download all attachments as: .zip

Change History (4)

@johnjamesjacoby
12 years ago

#1 @ocean90
12 years ago

  • Milestone changed from 3.6 to Awaiting Review

Since we have a HTML5 doctype the div in a th is valid. The content model of a th element is "​Flow content, but with no header, footer, sectioning content, or heading content descendants" and a div is ​an element of the flow content category.

The //<![CDATA[ inside of <script> aren't needed here too. It's more for XHTML.

#2 @SergeyBiryukov
12 years ago

  • Component changed from General to Administration
  • Keywords dev-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

See #18788 for removing CDATA.

#3 @johnjamesjacoby
12 years ago

Oh, HTML5 and your new fangled rules. Thanks for the education y'all.

Note: See TracTickets for help on using tickets.