WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#23962 closed defect (bug) (fixed)

Twenty Thirteen: Gallery post format missing styles for category links

Reported by: ziegenberg Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: Cc:

Description

The post format "Gallery" is missing some styling for the category links. The category names itself have different colouring than the commas separating them whereas the tag names have the same colouring as their separating commas.

Solution: Add missing selector .format-gallery span.categories-links.

Attachments (3)

23924.patch (484 bytes) - added by ziegenberg 2 years ago.
23933.patch (605 bytes) - added by ziegenberg 2 years ago.
23962.1.diff (897 bytes) - added by obenland 2 years ago.

Download all attachments as: .zip

Change History (12)

@ziegenberg2 years ago

comment:1 @ziegenberg2 years ago

  • Version set to trunk

comment:2 @obenland2 years ago

It actually should be the other way around: Unlinked text should remain the same color as the rest of the text. Like the sticky text.

Would you mind updating your patch? I think we can remove most of the .tag-links adjustments.

comment:3 @lancewillett2 years ago

  • Keywords needs-refresh added

@ziegenberg2 years ago

comment:4 @ziegenberg2 years ago

  • Keywords needs-testing added; needs-refresh removed

I updated the patch and removed all .tag-links adjustments (2 occurrences) where they changed the style of listings in the category or tag listings.

comment:5 @lancewillett2 years ago

  • Milestone changed from Awaiting Review to 3.6

comment:6 @obenland2 years ago

There is more we can do here I think. Did you check the media queries and the default declaration?

comment:7 @lancewillett2 years ago

  • Summary changed from Twenty Thirteen: Post-Format Gallery missing styling in categorie links to Twenty Thirteen: Gallery post format missing styles for category links

comment:8 @ziegenberg2 years ago

I did a grep on .tags-links and .categories-links and that are the rules I've found altering the colouring. I didn't touch the rules hiding tags and categories completely for status and others.

Version 0, edited 2 years ago by ziegenberg (next)

@obenland2 years ago

comment:9 @lancewillett2 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23944:

Twenty Thirteen: remove overly-specific post meta styles, props ziegenberg and obenland. Fixes #23962.

Note: See TracTickets for help on using tickets.