Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#23984 closed defect (bug) (fixed)

Thickbox top margin

Reported by: tillkruess Owned by: markjaquith
Milestone: 3.6 Priority: normal
Severity: minor Version: 2.8
Component: Themes Keywords: has-patch
Focuses: Cc:


The "theme update details" popup looks funky, the thickbox titlebar is hidden behind WP's adminbar: http://cl.ly/image/2m27131t3508

Attachments (2)

23984.patch (8.2 KB) - added by ParadisePorridge 3 years ago.
23984.2.patch (1.5 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
3 years ago

  • Component changed from Toolbar to Themes

#2 @ParadisePorridge
3 years ago

  • Keywords has-patch added

#3 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 3.6
  • Version changed from trunk to 2.8

Introduced in [10592]. In 2.7, the thickbox resizing for "View version %s Details" link was properly handled by theme-preview.js too.

There's no need to patch minified files, a post-commit bot takes care of that.

The approach in 23984.patch appears to be correct. We do the same for plugins:

23984.2.patch keeps the fixed width and fixes the same issue on Themes screen in network admin.

#4 @markjaquith
2 years ago

See also: #10955 :-)

#5 @markjaquith
2 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 24558:

Keep the theme update thickbox from being obscured by the toolbar.

props ParadisePorridge, SergeyBiryukov. fixes #23984.

Note: See TracTickets for help on using tickets.