WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 7 years ago

Last modified 6 years ago

#23988 closed enhancement (fixed)

Add post info on comment.php?action=editcomment

Reported by: jenmylo Owned by:
Milestone: 4.2 Priority: normal
Severity: minor Version: 3.5.1
Component: Comments Keywords: has-patch
Focuses: ui, administration Cc:

Description

When you get a comment notification, if you click on a link to mark as spam, etc, when you get to the edit comment screen, there's no indication of which post/page the comment was in response to, which can be a determining factor in deciding if a comment is valuable, off-topic, or spam.

We should add an "In response to" area that lists the post title, date/timestamp like on comment list screen. If it's in response to another comment that should show as well, but since we don't have that in comment screen functionality yet, at least adding the post info that we already have and show on the list would be a clue and a step in the right direction.

Attachments (11)

edit-form-comment.diff (626 bytes) - added by Thaicloud 8 years ago.
Adds "In Response To: Post Title" to comment edit page
23988-edit-comment.diff (1.1 KB) - added by seanchayes 8 years ago.
23988-edit-comment-patch.jpg (69.8 KB) - added by seanchayes 8 years ago.
23988-edit-comment-patch-02.jpg (69.3 KB) - added by seanchayes 8 years ago.
23988-edit-comment-2.diff (1.2 KB) - added by Thaicloud 8 years ago.
Move response/reply info to status meta box
23988-comment-info-status.png (57.8 KB) - added by Thaicloud 8 years ago.
23988-edit-comment-3.diff (1.3 KB) - added by Thaicloud 7 years ago.
23988.moderate-comment.png (15.4 KB) - added by SergeyBiryukov 7 years ago.
23988.diff (1.6 KB) - added by adamsilverstein 7 years ago.
add comment post and parent info to comment moderation screen
23988.2.diff (6.2 KB) - added by helen 7 years ago.
23988.3.diff (1.2 KB) - added by ocean90 7 years ago.

Download all attachments as: .zip

Change History (35)

#1 @toscho
9 years ago

  • Cc info@… added

@Thaicloud
8 years ago

Adds "In Response To: Post Title" to comment edit page

#2 @Thaicloud
8 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#3 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 3.9

#4 @seanchayes
8 years ago

  • Keywords ui-feedback added

I looked at the original patch and it worked as expected.

Inspired, I re-wrote the patch to add the following information in the Author meta box on the comment.php?action=editcomment:

  • "In response to" <link to post>
  • "In reply to" <link to parent comment>

For each section there is a link to the original post and the post it's a reply to (where appropriate). I did re-use variants of existing comment code from the comment list screen /wp-admin/comment.php.

(See attached images)

Potentially we could place this additional information to the Status meta box (on the right hand side where the date/time and other status information is shown) so comments encouraged if that's where it might fit logically.

Further inspired I also wrote some changes to the Moderate Comment /wp-admin/comment.php?action=approve/spam/trash screen - I can include the patch this in this ticket or if the best practice is to open a new ticket I can do that. But in principle the same additional information is displayed to that screen.

#5 @rhyswynne
8 years ago

Tested seanchayes patch and it works as expected.

#6 @mordauk
8 years ago

Patch looks good to me.

#7 follow-up: @helen
8 years ago

  • Focuses ui administration added
  • Keywords needs-patch added; has-patch needs-testing ui-feedback removed

That info doesn't belong in the author box - it's not a part of the author info. Probably more appropriate in the status meta box. I think this ticket was actually meant about the Moderate Comment screen, though. Feel free to combine the patches into one.

#9 @helen
8 years ago

  • Milestone changed from 3.9 to Future Release

Needs a new patch; punting.

@Thaicloud
8 years ago

Move response/reply info to status meta box

#10 @Thaicloud
8 years ago

  • Keywords needs-testing has-patch added; needs-patch removed

#11 @SergeyBiryukov
8 years ago

  • Keywords 4.0-early added

#12 @Thaicloud
7 years ago

  • Keywords 4.0-early removed

This diff is just a cleaned up version of the previous one- I moved the divs within the if-statements and check to make sure the comment meta is set before output.

#13 in reply to: ↑ 7 @SergeyBiryukov
7 years ago

Replying to helen:

I think this ticket was actually meant about the Moderate Comment screen, though.

That's my understanding as well. To clarify, it's the screen you get to when you click an Approve/Trash/Spam link in the new comment email (see the screenshot).

The patch should add the post and parent comment information there as well.

@adamsilverstein
7 years ago

add comment post and parent info to comment moderation screen

#14 @adamsilverstein
7 years ago

  • Keywords dev-feedback added

Trying to solve the original issue Jen raised in this ticket.

In 23988.diff:

  • Add details about the post, comment timestamp and comment parent if available.
  • Based on code in class-wp-comments-list-table.php

Looks like this:

http://f.cl.ly/items/3B1B0a2726171h0d3W3e/Moderate_Comment__sadasd__WordPress_2015-02-02_22-34-55.jpg

@helen
7 years ago

#15 @helen
7 years ago

  • Keywords needs-testing dev-feedback removed
  • Milestone changed from Future Release to 4.2

23988.2.diff consolidates the patches, makes some string tweaks (including string reuse), and starts on some better design and flow treatment for the moderation screen. @michael-arestad is going to look at some further design treatment, e.g. Gravatar, etc. Screenshots:

http://s.hyhs.me/Zc5k/image.png

http://s.hyhs.me/ZcCQ/image.png http://s.hyhs.me/Zc4w/image.png

#16 @helen
7 years ago

Note (as much for myself as anybody else): there's a .button-cancel class that can be used. Also: I just noticed the short border under "Status" in the submit box, should probably fix that to match regular post boxes as well.

#17 @helen
7 years ago

I'm going to commit what we've got here so far, as it's significantly better than what's currently there. I'll leave it open in case somebody wants to tackle mocking up a bigger visual change (Gravatar, etc. - that is to say, make it feel like a comment) in the next couple days before beta, but we'll likely need to spin that off into another ticket and do it later.

#18 @helen
7 years ago

In 31641:

Comments: Show more identifying information for moderation and editing.

Attempting to moderate comments without context about the post is more difficult than necessary. The comment moderation screen you are sent to via email link was also in need of some better visual treatment.

props thaicloud, seanchayes, adamsilverstein.
see #23988.

#19 @helen
7 years ago

In addition to the aforementioned possible bigger visual changes, I neglected to investigate the short border underneath "Status" in the metabox, and I noticed that comment HTML is escaped. I think the latter may be on purpose, based on [5543], and is certainly safer. It's not very pretty, though.

@ocean90
7 years ago

#20 follow-up: @ocean90
7 years ago

23988.3.diff moves $comment_url out of if ( $comment->comment_parent ) {} and applies the .notice-info class to the current status message.

#21 in reply to: ↑ 20 @helen
7 years ago

Replying to ocean90:

23988.3.diff moves $comment_url out of if ( $comment->comment_parent ) {} and applies the .notice-info class to the current status message.

Did you mean to leave it commented out like that? :) Feel free to commit it.

#22 @ocean90
7 years ago

In 31695:

Comments: Fix undefined $comment_url variable notice, introduced in [31641].

see #23988.

#23 @helen
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I don't see us getting to bigger visual changes by today. I think we can make some relatively incremental changes here in the future around making this more like a comment when you arrive here (since it's coming from the context of an email), but I also think that big picture, there's a lot of room for improvement of the comment management experience in WordPress. Worth some UX exploration :)

#24 @rachelbaker
6 years ago

In 36173:

Comments: Remove orphaned closing td tag within cancel button of Moderate Comment screen.

Left behind in r31641. See #23988.

Props ash.matadeen.

Note: See TracTickets for help on using tickets.