Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#23997 closed defect (bug) (fixed)

Twenty Thirteen: Search Box Alignment IE9

Reported by: RDall Owned by: lancewillett
Priority: normal Milestone: 3.6
Component: Bundled Theme Version: 3.6
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

On Windows 7 IE 9 The search box is not vertically centered in the nav bar. Also there is no text "search..." in the input box and no search icon as seen in FF on the mac.

See Screenshot:
http://cl.ly/image/1m2X202D0w3O

Attachments (1)

23997.diff (1.0 KB ) - added by obenland 13 years ago.

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
13 years ago

  • Summary Search Box Alignment IE9Twenty Thirteen: Search Box Alignment IE9

#2 @lancewillett
13 years ago

  • Milestone Awaiting Review3.6

#3 @obenland
13 years ago

IE9 does not support placeholders. Not sure how much we can do about the alignment issue either.

#4 @RDall
13 years ago

Doesn't Twenty-Thirteen have it's own IE style sheet?

#5 @mjbanks
13 years ago

Could always add an IE9 conditional to the <html> element in addition to IE7 and IE8 to tweak the IE9 specific styles.

As for placeholders, what about using jquery.placeholder - https://github.com/mathiasbynens/jquery-placeholder - if the browser doesn't support HTML5 placeholders, it will drop them into place, but do nothing if the browser supports it.

@obenland
13 years ago

#6 @obenland
13 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

IE9 doesn't know what a search input type is. Patch adds a fallback for outdated browsers.

#7 @lancewillett
13 years ago

@obenland Should the older selectors just go into IE file instead?

#8 @obenland
13 years ago

ie.css doesn't get loaded for IE9. Also there may be other browsers out there that might not support search type inputs.

#9 @lancewillett
13 years ago

  • Owner set to lancewillett
  • Resolutionfixed
  • Status newclosed

In 23961:

Twenty Thirteen: add fallback selectors for older browsers that don't understand search input elements. Fixes #23997, props obenland.

#10 @lancewillett
13 years ago

  • Keywords needs-testing removed
  • Resolution fixed
  • Status closedreopened

Looking at IE7 today, saw the search field wasn't usable.

#11 follow-up: @RDall
13 years ago

I didn't think WP was still supporting IE7 ? My Bad… 

#12 @lancewillett
13 years ago

  • Resolutionfixed
  • Status reopenedclosed

In 24035:

Twenty Thirteen: search form fixes for IE7, and add fallback search type selector to RTL stylesheet, see r23961. Closes #23997.

#13 in reply to: ↑ 11 @SergeyBiryukov
13 years ago

Replying to RDall:

I didn't think WP was still supporting IE7 ? My Bad… 

See #18199.

Note: See TracTickets for help on using tickets.