Quote post format should use content for content of the quote

[markjaquith]

The balance of the quote post format seems off. The quote is the main content piece, and having commentary makes it less distinct as a format.

I think we should refactor so that the quote content is the post editor.

So, like chat, there would be no concept of commentary/remaining-content with this format.

[saracannon]

This makes sense - users could always end up using BlockQuote and then regular text if they happen to want commentary

[alexkingorg]

Another benefit, the quote text is searchable using standard WP search.

[kovshenin]

First pass in 24009.diff​:

• Remove the extra quote content field and meta key from various places
• Add a new get_content_quote function to grab/replace a quote from content
• New get_the_post_format_quote and the_post_format_quote functions that return/print the resulting blockquote
• Adjust query.php to allow quotes to be split from the remaining content
• Compat routine that replaces the found blockquote with a new structured one

[DrewAPicture]

24009.2.diff​ fleshes out the docblocks a bit, also added an esc_html() around the quote source.

We may need to look at back-compat for <figcaption> for IE7/8, or, if it just fails silently, leave a note for theme authors.

[obenland]

Replying to DrewAPicture:

24009.2.diff​ [...] added an esc_html() around the quote source.

I'm not sure we want do that. It would render the use of <cite> tags useless that are used for works. The final quote should look ​like this.

We may need to look at back-compat for <figcaption> for IE7/8, or, if it just fails silently, leave a note for theme authors.

Have you had any problems with it? IE should just ignore them, no? I had no errors showing up in tests with Kubrick.

[kovshenin]

I agree with @obenland about esc_html. Also, doing esc_html when a source URL exists, and not doing it when source URL is empty is somewhat confusing.

[DrewAPicture]

Removes esc_html on quote source

[DrewAPicture]

Replying to obenland:

Replying to DrewAPicture:

24009.2.diff​ [...] added an esc_html() around the quote source.

I'm not sure we want do that. It would render the use of <cite> tags useless that are used for works. The final quote should look ​like this.

Good call, good call. Covered in 24009.3.diff​, also refreshed against trunk.

[markjaquith]

Updates the prompt text.

[DrewAPicture]

Refresh

[DrewAPicture]

24009.5.diff​ rerefreshes against trunk following this morning's commits.

[markjaquith]

Fixes the refresh. A few meta keys weren't right, so compat fallback wasn't working.

[markjaquith]

In 24034:

Post Formats: use the content body for the body of the Quote post format.

• Searchable, better editing tools
• Less cluttered Post Format UI

props kovshenin, DrewAPicture. see #24009

[kovshenin]

Thanks for the commit! Just noticed one tiny thing in the docblock for get_content_quote. If the $replace argument is not empty, replacement will occur regardless of whether $remove is true or false. See 24009.7.diff​.

[SergeyBiryukov]

In 24045:

Correct phpdoc for get_content_quote(). props kovshenin. see #24009.

[wonderboymusic]

.8.diff ditches the _format_quote meta key / field / etc

[wonderboymusic]

This is confirmed working - quirks in the theme can be / are reported elsewhere