Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24031 closed defect (bug) (fixed)

CSS3 transition property can affect the Admin Bar

Reported by: kwight's profile kwight Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.1
Component: Toolbar Keywords: has-patch commit
Focuses: Cc:

Description

Adding the transition property to, say, all anchors in a theme can affect Admin Bar elements. Explicitly setting transition to none can stop unexpected behaviour.

Attachments (2)

24031.diff (457 bytes) - added by kwight 11 years ago.
24031.2.diff (478 bytes) - added by SergeyBiryukov 11 years ago.
With proper formatting

Download all attachments as: .zip

Change History (8)

@kwight
11 years ago

#1 @kwight
11 years ago

An example theme is Superhero (see L304 of style.css): http://wordpress.org/extend/themes/superhero

@SergeyBiryukov
11 years ago

With proper formatting

#2 @SergeyBiryukov
11 years ago

  • Component changed from General to Toolbar
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.6
  • Version changed from trunk to 3.1

This would be consistent with the previous CSS fixes in [17064], [17626], and [22280].

See CSS Coding Standards for the preferred formatting of vendor prefixes.

Do we also need -ms-transition? We use it in every other instance of transition properties in core.

#3 @kwight
11 years ago

The vendor prefix was used briefly in IE10, perhaps during development, but isn't necessary now: http://msdn.microsoft.com/en-us/library/ie/hh673535(v=vs.85).aspx

With or without the prefix, it's not supported at all in IE9 and below, according to my testing with this IE test page: http://ie.microsoft.com/testdrive/Graphics/hands-on-css3/hands-on_transitions.htm

#4 @helen
11 years ago

We should probably remove anything -ms-*, as it's not actually supported in any production/stable version of IE as far as I know.

#5 @SergeyBiryukov
11 years ago

  • Keywords commit added

#6 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23951:

Reset transition property in toolbar CSS to avoid conflicts with themes. props kwight. fixes #24031.

Note: See TracTickets for help on using tickets.