WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#24033 closed enhancement (fixed)

Bundled themes: add identifier to `style` elements added by the theme

Reported by: lancewillett's profile lancewillett Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

To assist in debugging CSS in a site's output, I suggest adding an ID attribute to identify style elements that default themes add to the head element.

Attachments (2)

24033.diff​ (2.7 KB) - added by lancewillett 11 years ago.
24033.2.diff​ (599 bytes) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (7)

@lancewillett
11 years ago

#1 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24001:

Bundled themes: add identifier to style elements added by the theme. Fixes #24033.

@SergeyBiryukov
11 years ago

#2 follow-up: @SergeyBiryukov
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

In Twenty Twelve, id attributes in twentytwelve_header_style() and twentytwelve_admin_header_style() are the same, however in Eleven and Thirteen they are different. Is that intentional?

#3 in reply to: ↑ 2 @lancewillett
11 years ago

Replying to SergeyBiryukov:

In Twenty Twelve, id attributes in twentytwelve_header_style() and twentytwelve_admin_header_style() are the same, however in Eleven and Thirteen they are different. Is that intentional?

Not intentional, thanks for the catch, and patch.

#4 @lancewillett
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 24016:

Twenty Twelve: fix style element ID attribute value, props SergeyBiryukov. Closes #24033.

#5 @lancewillett
11 years ago

In 24145:

Twenty Ten: fix style element ID attribute value, see #24033.

Note: See TracTickets for help on using tickets.