WordPress.org

Make WordPress Core

#24039 closed defect (bug) (fixed)

Twenty Thirteen: Increase comment form label widths

Reported by: obenland Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

In languages other than English, the comment form labels might be longer than 100px. Let's increase the width here and also be a bit more specific about which labels we mean exactly.

Attachments (2)

24039.diff (812 bytes) - added by obenland 12 months ago.
24039.1.diff (1.3 KB) - added by lancewillett 12 months ago.

Download all attachments as: .zip

Change History (6)

obenland12 months ago

comment:1 follow-up: lancewillett12 months ago

The width change is probably OK, but I don't agree with more specific selectors.

See http://core.trac.wordpress.org/ticket/23702#comment:3 and r23690 -- we went more general on purpose.

comment:2 in reply to: ↑ 1 obenland12 months ago

Replying to lancewillett:

I don't agree with more specific selectors.

See http://core.trac.wordpress.org/ticket/23702#comment:3 and r23690 -- we went more general on purpose.

I changed my mind :)

With more specific selectors we avoid stomping all over labels that are injected by plugins. Like Jetpacks subscribe to comments or captcha plugins.

lancewillett12 months ago

comment:3 lancewillett12 months ago

.1 adds similar spacing for comment label, and also RTL support.

comment:4 lancewillett12 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23967:

Twenty Thirteen: improve comment label selectors and nudge up their width a bit to account for non-English installs. Props obenland for initial patch, fixes #24039.

Note: See TracTickets for help on using tickets.