WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#24039 closed defect (bug) (fixed)

Twenty Thirteen: Increase comment form label widths

Reported by: obenland Owned by: lancewillett
Priority: normal Milestone: 3.6
Component: Bundled Theme Version: 3.6
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

In languages other than English, the comment form labels might be longer than 100px. Let's increase the width here and also be a bit more specific about which labels we mean exactly.

Attachments (2)

24039.diff​ (812 bytes ) - added by obenland 13 years ago.
24039.1.diff​ (1.3 KB ) - added by lancewillett 13 years ago.

Download all attachments as: .zip

Change History (6)

@obenland
13 years ago

#1 follow-up: @lancewillett
13 years ago

The width change is probably OK, but I don't agree with more specific selectors.

See ​http://core.trac.wordpress.org/ticket/23702#comment:3 and r23690 -- we went more general on purpose.

#2 in reply to: ↑ 1 @obenland
13 years ago

Replying to lancewillett:

I don't agree with more specific selectors.

See ​http://core.trac.wordpress.org/ticket/23702#comment:3 and r23690 -- we went more general on purpose.

I changed my mind :)

With more specific selectors we avoid stomping all over labels that are injected by plugins. Like Jetpacks subscribe to comments or captcha plugins.

@lancewillett
13 years ago

#3 @lancewillett
13 years ago

.1 adds similar spacing for comment label, and also RTL support.

#4 @lancewillett
13 years ago

  • Owner set to lancewillett
  • Resolution → fixed
  • Status new → closed

In 23967:

Twenty Thirteen: improve comment label selectors and nudge up their width a bit to account for non-English installs. Props obenland for initial patch, fixes #24039.

Note: See TracTickets for help on using tickets.