Force gallery state for gallery post format

[lessbloat]

One of the items uncovered with the ​last round of usability tests was that users don't know that they are not adding a gallery.

When the gallery post format is selected, and the user clicks the "Add Media" button, we should take them to the gallery section of the media modal.

[lessbloat]

24062.diff​ is a first attempt at making this happen. I'll include this patch in the next round of usability tests that I run.

[wonderboymusic]

Patch refreshed / cleaned up against trunk

[markjaquith]

In 24087:

Force gallery state for gallery post format.

props lessbloat, wonderboymusic. fixes #24062.

[markjaquith]

In 24088:

Clean up gallery-mode toggling in post-formats.js and make sure it is set on first load.

see #24062

[programmin]

Are you certain it is necessary to remove the

if ( workflow )
	return workflow

from the add function? Without this, current modifications that depend on getting a reference from the wp.media.editor.add function will break the uploading functionality, since other calls to add will create it again.

I have detailed the problem in this posting, if this can't be fixed I hope we can document a workaround.

​http://lists.automattic.com/pipermail/wp-hackers/2013-May/046124.html

[adamsilverstein]

reintroduce if ( workflow ) check

[adamsilverstein]

Replying to programmin:

Are you certain it is necessary to remove the

if ( workflow )
	return workflow

from the add function? Without this, current modifications that depend on getting a reference from the wp.media.editor.add function will break the uploading functionality, since other calls to add will create it again.

I have detailed the problem in this posting, if this can't be fixed I hope we can document a workaround.

​http://lists.automattic.com/pipermail/wp-hackers/2013-May/046124.html

24062.3.diff​​ reintroduces the if ( workflow ) check & return

[ocean90]

[24388] / #24452

[SergeyBiryukov]

24062.3.diff​ still seems valid.

[markjaquith]

In 24447:

Restore code that returns the existing media object if it already exists.

props programmin, adamsilverstein. fixes #24062