Opened 12 years ago
Closed 11 years ago
#24062 closed defect (bug) (fixed)
Force gallery state for gallery post format
Reported by: | lessbloat | Owned by: | markjaquith |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Post Formats | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
One of the items uncovered with the last round of usability tests was that users don't know that they are not adding a gallery.
When the gallery post format is selected, and the user clicks the "Add Media" button, we should take them to the gallery section of the media modal.
Attachments (3)
Change History (13)
#3
@
12 years ago
- Owner set to markjaquith
- Resolution set to fixed
- Status changed from new to closed
In 24087:
#5
follow-up:
↓ 6
@
12 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Are you certain it is necessary to remove the
if ( workflow ) return workflow
from the add function? Without this, current modifications that depend on getting a reference from the wp.media.editor.add function will break the uploading functionality, since other calls to add will create it again.
I have detailed the problem in this posting, if this can't be fixed I hope we can document a workaround.
http://lists.automattic.com/pipermail/wp-hackers/2013-May/046124.html
#6
in reply to:
↑ 5
@
12 years ago
Replying to programmin:
Are you certain it is necessary to remove the
if ( workflow ) return workflowfrom the add function? Without this, current modifications that depend on getting a reference from the wp.media.editor.add function will break the uploading functionality, since other calls to add will create it again.
I have detailed the problem in this posting, if this can't be fixed I hope we can document a workaround.
http://lists.automattic.com/pipermail/wp-hackers/2013-May/046124.html
24062.3.diff reintroduces the if ( workflow )
check & return
#7
@
11 years ago
- Keywords needs-testing removed
- Milestone 3.6 deleted
- Resolution set to invalid
- Status changed from reopened to closed
#8
@
11 years ago
- Milestone set to 3.6
- Resolution invalid deleted
- Status changed from closed to reopened
- Version set to trunk
24062.3.diff still seems valid.
24062.diff is a first attempt at making this happen. I'll include this patch in the next round of usability tests that I run.