WordPress.org

Make WordPress Core

Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#24087 closed enhancement (invalid)

Missing double slash on Javascript snippet on wp-admin/includes/file.php

Reported by: satollo Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Administration Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

There is a minor (may be formal) error on javascript generated by wp-admin/includes/file.php: the last --> that closes the HTML comment should be preceded by the Javascript comment marker .

Stefano.

Here the patch:

# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
--- Base (BASE)
+++ Locally Modified (Based On LOCAL)
@@ -977,7 +977,7 @@
 	});
 	jQuery('form input[value=""]:first').focus();
 });
--->
+//-->
 </script>
 <form action="<?php echo esc_url( $form_post ) ?>" method="post">
 <div class="wrap">

Change History (3)

comment:1 @satollo23 months ago

  • Keywords needs-patch added; has-patch removed

comment:2 @SergeyBiryukov23 months ago

  • Component changed from General to Administration
  • Keywords needs-patch removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
  • Version trunk deleted

There's no double slash before the opening comment tag either:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/file.php#L969

As noted in #23952, those comment tags are no longer needed. #18788 removes most of them, I've made a note there.

comment:3 @SergeyBiryukov23 months ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.