WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#24089 closed enhancement (fixed)

array_keys( get_post_format_slugs() ) is redundant

Reported by: SergeyBiryukov Owned by: markjaquith
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.1
Component: Post Formats Keywords: has-patch commit
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Initially, post format slugs used to be translatable ([16705]), so we had to use array_keys() to get the original values. See [17213], [17224].

Since [17391], the slugs are no longer translatable, so array_keys( get_post_format_slugs() ) is redundant.

Attachments (2)

24089.patch (1.5 KB) - added by SergeyBiryukov 7 years ago.
24089.diff (2.1 KB) - added by wonderboymusic 7 years ago.

Download all attachments as: .zip

Change History (5)

#1 @SergeyBiryukov
7 years ago

  • Description modified (diff)

@wonderboymusic
7 years ago

#2 @wonderboymusic
7 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.6

#3 @markjaquith
7 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 24082:

Fix redundant use of array_keys() around get_post_format_slugs().

props SergeyBirkukov, wonderboymusic. fixes #24089.

Note: See TracTickets for help on using tickets.