WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#24089 closed enhancement (fixed)

array_keys( get_post_format_slugs() ) is redundant

Reported by: SergeyBiryukov Owned by: markjaquith
Priority: normal Milestone: 3.6
Component: Post Formats Version: 3.1
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description (last modified by SergeyBiryukov)

Initially, post format slugs used to be translatable ([16705]), so we had to use array_keys() to get the original values. See [17213], [17224].

Since [17391], the slugs are no longer translatable, so array_keys( get_post_format_slugs() ) is redundant.

Attachments (2)

24089.patch​ (1.5 KB ) - added by SergeyBiryukov 13 years ago.
24089.diff​ (2.1 KB ) - added by wonderboymusic 13 years ago.

Download all attachments as: .zip

Change History (5)

@SergeyBiryukov
13 years ago

#1 @SergeyBiryukov
13 years ago

  • Description modified (diff)

@wonderboymusic
13 years ago

#2 @wonderboymusic
13 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 3.6

#3 @markjaquith
13 years ago

  • Owner set to markjaquith
  • Resolution → fixed
  • Status new → closed

In 24082:

Fix redundant use of array_keys() around get_post_format_slugs().

props SergeyBirkukov, wonderboymusic. fixes #24089.

Note: See TracTickets for help on using tickets.