#24096 closed enhancement (fixed)
Restore option to change post format in Bulk Edit box
Reported by: | alexvorn2 | Owned by: | helen |
---|---|---|---|
Milestone: | 3.7 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Post Formats | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
For a faster change inline - to other format, add this option.
Attachments (4)
Change History (19)
#1
@
12 years ago
- Component changed from General to Post Formats
- Keywords close added
- Version set to trunk
#2
@
12 years ago
jrbeilke mentioned a valid use case in IRC: people might want to set format for a bunch of old posts.
#3
@
12 years ago
Would be okay with restoring in bulk edit; still stand by it not being a good fit for quick edit.
#4
@
12 years ago
- Keywords close removed
- Milestone changed from Awaiting Review to 3.6
- Summary changed from Add option to change post format in Quick Edit box to Restore option to change post format in Bulk Edit box
#5
@
12 years ago
- Cc xoodrew@… added
- Keywords has-patch added
24096.diff restores formats to bulk edit.
#6
follow-up:
↓ 7
@
12 years ago
In 24096.diff you would want to unset $post_data['post_format']
when it hasn't been changed, i.e. it's = -1. Perhaps add 'post_format'
to the $reset
array.
#7
in reply to:
↑ 6
@
12 years ago
Replying to azaozz:
In 24096.diff you would want to unset
$post_data['post_format']
when it hasn't been changed, i.e. it's = -1. Perhaps add'post_format'
to the$reset
array.
Good call, done in 24096.2.diff.
#11
@
11 years ago
24096.3.diff replaces _ex( 'Standard', 'Post format' )
with echo get_post_format_string( 'standard' )
for consistency with [24522].
#12
@
11 years ago
24096.3.diff looks good to me.
#13
@
11 years ago
Wow, class-wp-posts-list-table.php has really bad formatting. The HTML is indented instead of the PHP and the multiple nested if ( #condition ) : ... endif;
make it really hard to read :)
The posts list-table Quick Edit and Bulk Edit really really need a refactoring. The HTML and CSS are still IE6 compat, the JS is... old, the whole row scales pretty bad in a narrower window and is not responsive. All this can be done much cleaner now. Also the newly added Format drop-down pushes it down while there is some free space on the right.
In 24096.4.diff:
- Removed setting the 'standard' post format to '0', and then to 'false'. Don't see a good reason for that,
set_post_format()
is clever enough to set empty or 'standard' post format correctly. - Removed
<div class="inline-edit-group">
that reserves a separate row only for the Format drop-down. Doesn't make any difference at the moment and eventually all drop-downs under the Tags textarea should be inline-blocks so they can wrap when less are shown. - Added a check whether the post type supports post formats.
It was intentionally removed in #23426.