WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#24096 closed enhancement (fixed)

Restore option to change post format in Bulk Edit box

Reported by: alexvorn2 Owned by: helen
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.6
Component: Post Formats Keywords: has-patch commit
Focuses: Cc:

Description

For a faster change inline - to other format, add this option.

http://media.share.pho.to/1rFYs/7a29bd21_o.png

Attachments (4)

24096.diff (1.9 KB) - added by DrewAPicture 6 years ago.
24096.2.diff (2.5 KB) - added by DrewAPicture 6 years ago.
24096.3.diff (2.6 KB) - added by SergeyBiryukov 6 years ago.
24096.4.diff (2.1 KB) - added by azaozz 6 years ago.

Download all attachments as: .zip

Change History (19)

#1 @SergeyBiryukov
6 years ago

  • Component changed from General to Post Formats
  • Keywords close added
  • Version set to trunk

It was intentionally removed in #23426.

#2 @SergeyBiryukov
6 years ago

jrbeilke mentioned a valid use case in IRC: people might want to set format for a bunch of old posts.

#3 @helen
6 years ago

Would be okay with restoring in bulk edit; still stand by it not being a good fit for quick edit.

#4 @SergeyBiryukov
6 years ago

  • Keywords close removed
  • Milestone changed from Awaiting Review to 3.6
  • Summary changed from Add option to change post format in Quick Edit box to Restore option to change post format in Bulk Edit box

@DrewAPicture
6 years ago

#5 @DrewAPicture
6 years ago

  • Cc xoodrew@… added
  • Keywords has-patch added

24096.diff restores formats to bulk edit.

#6 follow-up: @azaozz
6 years ago

In 24096.diff​ you would want to unset $post_data['post_format'] when it hasn't been changed, i.e. it's = -1. Perhaps add 'post_format' to the $reset array.

@DrewAPicture
6 years ago

#7 in reply to: ↑ 6 @DrewAPicture
6 years ago

Replying to azaozz:

In 24096.diff​ you would want to unset $post_data['post_format'] when it hasn't been changed, i.e. it's = -1. Perhaps add 'post_format' to the $reset array.

Good call, done in 24096.2.diff.

#8 @wonderboymusic
6 years ago

  • Keywords commit added

#9 @ocean90
6 years ago

  • Milestone changed from 3.6 to Future Release

#10 @obenland
6 years ago

  • Milestone changed from Future Release to 3.7

#11 @SergeyBiryukov
6 years ago

24096.3.diff replaces _ex( 'Standard', 'Post format' ) with echo get_post_format_string( 'standard' ) for consistency with [24522].

#12 @DrewAPicture
6 years ago

24096.3.diff looks good to me.

@azaozz
6 years ago

#13 @azaozz
6 years ago

Wow, class-wp-posts-list-table.php has really bad formatting. The HTML is indented instead of the PHP and the multiple nested if ( #condition ) : ... endif; make it really hard to read :)

The posts list-table Quick Edit and Bulk Edit really really need a refactoring. The HTML and CSS are still IE6 compat, the JS is... old, the whole row scales pretty bad in a narrower window and is not responsive. All this can be done much cleaner now. Also the newly added Format drop-down pushes it down while there is some free space on the right.

In 24096.4.diff​:

  • Removed setting the 'standard' post format to '0', and then to 'false'. Don't see a good reason for that, set_post_format() is clever enough to set empty or 'standard' post format correctly.
  • Removed <div class="inline-edit-group"> that reserves a separate row only for the Format drop-down. Doesn't make any difference at the moment and eventually all drop-downs under the Tags textarea should be inline-blocks so they can wrap when less are shown.
  • Added a check whether the post type supports post formats.
Last edited 6 years ago by azaozz (previous) (diff)

#14 @helen
6 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 25505:

Restore post formats to bulk editing. props azaozz, SergeyBiryukov, DrewAPicture. fixes #24096.

#15 @afercia
3 years ago

In 36375:

Quick/Bulk Edit: Remove a no more used jQuery loop for unsupported post formats.

See #23426.
See #24096.
Fixes #35564.

Note: See TracTickets for help on using tickets.