WordPress.org

Make WordPress Core

Changes between Version 4 and Version 5 of Ticket #24104, comment 9


Ignore:
Timestamp:
10/13/2015 05:29:07 PM (4 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24104, comment 9

    v4 v5  
    1010And finally...
    1111* Move this entire routine after the `custom_menu_order` and `menu_order` filters have fired, but before the `$last_menu_key` separator check removes a trailing separator. This is important because plugins might be adding (and also relocating) separators to the `$menu` global at any point in `menu.php`'s life-cycle, and WordPress cannot confidently guess at adjacent separators until plugins have had the opportunity to reorder their custom menu items.
     12* We've always referred to this code as "checking for duplicates" when it really needs to "prevent adjacency." As such, it's never worked the way we've needed it to, though it did work the way it was originally described.
    1213
    1314----