Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#24113 closed defect (bug) (fixed)

Twenty Themes: Add support for immediate Header text removal

Reported by: obenland's profile obenland Owned by: nacin's profile nacin
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

There is a class that one can use in the admin header image callback, to support immediate removal of the header text, when the corresponding checkbox is checked, rather than waiting for saving the page.

Let's bring that to our default themes.

Attachments (1)

24113.diff (3.0 KB) - added by obenland 12 years ago.

Download all attachments as: .zip

Change History (7)

@obenland
12 years ago

#1 @obenland
12 years ago

  • Keywords commit added

#2 @lancewillett
12 years ago

Nice one.

Note: this is only for Appearance > Header plugin page, right? Not Theme Customizer.

#3 @lancewillett
12 years ago

Related note: both Twelve and Thirteen already have JS handling for hiding the title/decription in Theme Customizer, with header_textcolor value via postMessage. Eleven does not have that capability.

Last edited 12 years ago by lancewillett (previous) (diff)

#4 @obenland
12 years ago

Yes, this is in the admin header page.

#5 @lancewillett
12 years ago

  • Summary changed from Twenty Themes: Add support for immediate Header text removal. to Twenty Themes: Add support for immediate Header text removal

Added #24128 for Twenty Eleven postMessage and header_textcolor enhancement.

#6 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24050:

Add .displaying-header-text to the default themes, as the Custom Header page toggles this class. props obenland, fixes #24113.

Note: See TracTickets for help on using tickets.